[27.x][Agent] Additional changes to support Agent - Admin or Configure Agent Access Control without SUPER scenarios #6230
+12
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto releases/27.x
…nto releases/27.x
…nto releases/27.x
…nto releases/27.x
…nto releases/27.x
…t Access Control without SUPER scenarios (#6082) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> 1. Only enable the Setup action from the Agent List and Agent Card if the user has rights to manage this agent (via permissions or via Agent Access Control) 2. Removing the logic to insert the current owner on agent creation if none is found because this is handled via the server during agent creation already. Also, this code was inserting the Agent Access Control for all companies while the user might have had agent creation permissions in one company. 3. Use a new server utility when inserting Access Control for an agent. This allows users with only Configure Agent Access Control and without SUPER, SECURITY or AGENT - ADMIN to do such changes without explicitly having Access Control modification permissions. They can only do this on the agent they manage (and cannot do this on other agents or other user types). #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#617434](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617434)
qutreson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport of !6082
Work Item(s)
Fixes AB#617434
AB#617745