Skip to content

[Subcontracting] Align variable names to object names #6239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AleksandricMarko wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[Subcontracting] Align variable names to object names #6239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
822b1d7
variable name fix part 1
AleksandricMarko Jan 21, 2026
3743e89
fix
AleksandricMarko Jan 21, 2026
be49959
fix variable names part II
AleksandricMarko Jan 21, 2026
c7bcbbc
fix part II
AleksandricMarko Jan 21, 2026
b42dd27
fix
AleksandricMarko Jan 21, 2026
12ac3e0
fix
AleksandricMarko Jan 22, 2026
f4fcce8
fix
AleksandricMarko Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Apps/W1/Subcontracting/App/src/Install/SubcBusinessSetupExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ------------------------------------------------------------------------------------------------
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
// ------------------------------------------------------------------------------------------------
Expand All @@ -23,8 +23,8 @@ codeunit 99001502 "Subc. Business Setup Ext."
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Company-Initialize", OnCompanyInitialize, '', false, false)]
local procedure OnCompanyInitialize()
var
SubcontractingMgtCompInit: Codeunit "Subcontracting Comp. Init.";
SubcontractingCompInit: Codeunit "Subcontracting Comp. Init.";
begin
SubcontractingMgtCompInit.CreateBasicSubcontractingMgtSetup();
SubcontractingCompInit.CreateBasicSubcontractingMgtSetup();
end;
}
18 changes: 9 additions & 9 deletions src/Apps/W1/Subcontracting/App/src/Install/SubcontractingCompInit.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ------------------------------------------------------------------------------------------------
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
// ------------------------------------------------------------------------------------------------
Expand All @@ -16,15 +16,15 @@ codeunit 99001503 "Subcontracting Comp. Init."

local procedure CreateSubcontractingManagementSetup()
var
SubcontractingManagementSetup: Record "Subc. Management Setup";
SubcManagementSetup: Record "Subc. Management Setup";
begin
if not SubcontractingManagementSetup.Get() then begin
SubcontractingManagementSetup.Init();
CreateLaborReqWkshTemplateAndNameAndUpdateSetup(SubcontractingManagementSetup);
SubcontractingManagementSetup."Direct Transfer" := true;
SubcontractingManagementSetup."Create Prod. Order Info Line" := true;
Evaluate(SubcontractingManagementSetup."Subc. Inb. Whse. Handling Time", GetDefaultInboundWhseHandlingTime());
SubcontractingManagementSetup.Insert(true);
if not SubcManagementSetup.Get() then begin
SubcManagementSetup.Init();
CreateLaborReqWkshTemplateAndNameAndUpdateSetup(SubcManagementSetup);
SubcManagementSetup."Direct Transfer" := true;
SubcManagementSetup."Create Prod. Order Info Line" := true;
Evaluate(SubcManagementSetup."Subc. Inb. Whse. Handling Time", GetDefaultInboundWhseHandlingTime());
SubcManagementSetup.Insert(true);
end;
end;

Expand Down
10 changes: 5 additions & 5 deletions src/Apps/W1/Subcontracting/App/src/Install/SubcontractingInstall.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ------------------------------------------------------------------------------------------------
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
// ------------------------------------------------------------------------------------------------
Expand Down Expand Up @@ -33,16 +33,16 @@ codeunit 99001501 "Subcontracting Install"

local procedure HandleFreshInstallPerCompany()
var
SubcontractingCompanyInit: Codeunit "Subcontracting Comp. Init.";
SubcontractingCompInit: Codeunit "Subcontracting Comp. Init.";
begin
SubcontractingCompanyInit.CreateBasicSubcontractingMgtSetup();
SubcontractingCompInit.CreateBasicSubcontractingMgtSetup();
end;

local procedure HandleReinstallPerCompany()
var
SubcontractingCompanyInit: Codeunit "Subcontracting Comp. Init.";
SubcontractingCompInit: Codeunit "Subcontracting Comp. Init.";
begin
SubcontractingCompanyInit.CreateBasicSubcontractingMgtSetup();
SubcontractingCompInit.CreateBasicSubcontractingMgtSetup();
end;

local procedure HandleFreshInstallPerDatabase()
Expand Down
10 changes: 5 additions & 5 deletions ...cting/App/src/Process/Codeunits/Extensions/Manufacturing/SubcCalcProdOrderExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ------------------------------------------------------------------------------------------------
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
// ------------------------------------------------------------------------------------------------
Expand All @@ -13,12 +13,12 @@ codeunit 99001517 "Subc. Calc. Prod. Order Ext."
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Calculate Prod. Order", OnAfterTransferRoutingLine, '', false, false)]
local procedure OnAfterTransferRoutingLine(var ProdOrderLine: Record "Prod. Order Line"; var RoutingLine: Record "Routing Line"; var ProdOrderRoutingLine: Record "Prod. Order Routing Line")
var
SubPricingMgmt: Codeunit "Subc. Price Management";
SubSubcontractingMgmt: Codeunit "Subcontracting Management";
SubcPriceManagement: Codeunit "Subc. Price Management";
SubcontractingManagement: Codeunit "Subcontracting Management";
begin
SubSubcontractingMgmt.UpdateLinkedComponentsAfterRoutingTransfer(ProdOrderLine, RoutingLine, ProdOrderRoutingLine);
SubcontractingManagement.UpdateLinkedComponentsAfterRoutingTransfer(ProdOrderLine, RoutingLine, ProdOrderRoutingLine);

SubPricingMgmt.ApplySubcontractorPricingToProdOrderRouting(ProdOrderLine, RoutingLine, ProdOrderRoutingLine);
SubcPriceManagement.ApplySubcontractorPricingToProdOrderRouting(ProdOrderLine, RoutingLine, ProdOrderRoutingLine);
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"Calculate Prod. Order", OnAfterTransferBOMComponent, '', false, false)]
Expand Down
6 changes: 3 additions & 3 deletions ...ting/App/src/Process/Codeunits/Extensions/Manufacturing/SubcCreateProdRtngExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ------------------------------------------------------------------------------------------------
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
// ------------------------------------------------------------------------------------------------
Expand All @@ -13,8 +13,8 @@ codeunit 99001526 "Subc. Create Prod. Rtng. Ext."
[EventSubscriber(ObjectType::Report, Report::"Subc. Create Prod. Routing", OnAfterInsertRoutingHeader, '', false, false)]
local procedure OnAfterInsertRoutingHeader(RoutingHeader: Record "Routing Header")
var
SubcontractingMgmt: Codeunit "Subcontracting Management";
SubcontractingManagement: Codeunit "Subcontracting Management";
begin
SubcontractingMgmt.CreatePurchProvisionRoutingLine(RoutingHeader);
SubcontractingManagement.CreatePurchProvisionRoutingLine(RoutingHeader);
end;
}
28 changes: 14 additions & 14 deletions ...acting/App/src/Process/Codeunits/Extensions/Manufacturing/SubcPlanningCompExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ------------------------------------------------------------------------------------------------
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
// ------------------------------------------------------------------------------------------------
Expand Down Expand Up @@ -42,20 +42,20 @@ codeunit 99001522 "Subc. Planning Comp. Ext."

local procedure HandleRoutingLinkCodeValidation(var PlanningComponent: Record "Planning Component"; var xPlanningComponent: Record "Planning Component")
var
PlanningRtngLine: Record "Planning Routing Line";
SKU: Record "Stockkeeping Unit";
PlanningRoutingLine: Record "Planning Routing Line";
StockkeepingUnit: Record "Stockkeeping Unit";
Vendor: Record Vendor;
GetPlanningParameters: Codeunit "Planning-Get Parameters";
PlanningGetParameters: Codeunit "Planning-Get Parameters";
SubcontractingManagement: Codeunit "Subcontracting Management";
begin
if PlanningComponent."Routing Link Code" <> '' then begin
PlanningRtngLine.SetRange("Worksheet Template Name", PlanningComponent."Worksheet Template Name");
PlanningRtngLine.SetRange("Worksheet Batch Name", PlanningComponent."Worksheet Batch Name");
PlanningRtngLine.SetRange("Worksheet Line No.", PlanningComponent."Worksheet Line No.");
PlanningRtngLine.SetRange("Routing Link Code", PlanningComponent."Routing Link Code");
PlanningRtngLine.SetRange(Type, PlanningRtngLine.Type::"Work Center");
if PlanningRtngLine.FindFirst() then
if SubcontractingManagement.GetSubcontractor(PlanningRtngLine."No.", Vendor) then
PlanningRoutingLine.SetRange("Worksheet Template Name", PlanningComponent."Worksheet Template Name");
PlanningRoutingLine.SetRange("Worksheet Batch Name", PlanningComponent."Worksheet Batch Name");
PlanningRoutingLine.SetRange("Worksheet Line No.", PlanningComponent."Worksheet Line No.");
PlanningRoutingLine.SetRange("Routing Link Code", PlanningComponent."Routing Link Code");
PlanningRoutingLine.SetRange(Type, PlanningRoutingLine.Type::"Work Center");
if PlanningRoutingLine.FindFirst() then
if SubcontractingManagement.GetSubcontractor(PlanningRoutingLine."No.", Vendor) then
SubcontractingManagement.ChangeLocation_OnPlanningComponent(PlanningComponent, Vendor."Subcontr. Location Code", PlanningComponent."Orig. Location Code", PlanningComponent."Orig. Bin Code");
end else
if xPlanningComponent."Routing Link Code" <> '' then
Expand All @@ -67,12 +67,12 @@ codeunit 99001522 "Subc. Planning Comp. Ext."
PlanningComponent."Orig. Bin Code" := '';
end;
end else begin
GetPlanningParameters.AtSKU(
SKU,
PlanningGetParameters.AtSKU(
StockkeepingUnit,
PlanningComponent."Item No.",
PlanningComponent."Variant Code",
PlanningComponent."Location Code");
PlanningComponent.Validate(PlanningComponent."Location Code", SKU."Components at Location");
PlanningComponent.Validate(PlanningComponent."Location Code", StockkeepingUnit."Components at Location");
end;
end;

Expand Down
6 changes: 3 additions & 3 deletions ...ng/App/src/Process/Codeunits/Extensions/Manufacturing/SubcPlanningLineMgmtExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ------------------------------------------------------------------------------------------------
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
// ------------------------------------------------------------------------------------------------
Expand All @@ -19,8 +19,8 @@ codeunit 99001518 "Subc. Planning Line Mgmt Ext."
#endif
local procedure OnAfterTransferRtngLine(var ReqLine: Record "Requisition Line"; var RoutingLine: Record "Routing Line"; var PlanningRoutingLine: Record "Planning Routing Line")
var
SubPricingMgmt: Codeunit "Subc. Price Management";
SubcPriceManagement: Codeunit "Subc. Price Management";
begin
SubPricingMgmt.ApplySubcontractorPricingToPlanningRouting(ReqLine, RoutingLine, PlanningRoutingLine);
SubcPriceManagement.ApplySubcontractorPricingToPlanningRouting(ReqLine, RoutingLine, PlanningRoutingLine);
end;
}
54 changes: 27 additions & 27 deletions ...cting/App/src/Process/Codeunits/Extensions/Manufacturing/SubcProdOrderCompExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ------------------------------------------------------------------------------------------------
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
// ------------------------------------------------------------------------------------------------
Expand Down Expand Up @@ -53,21 +53,21 @@ codeunit 99001524 "Subc. Prod. Order Comp. Ext."

local procedure CheckExistingPostedSubcontractingTransferOrder(ProdOrderComponent: Record "Prod. Order Component"): Boolean
var
TransferShipLine: Record "Transfer Shipment Line";
ConfirmMgt: Codeunit "Confirm Management";
TransferShipmentLine: Record "Transfer Shipment Line";
ConfirmManagement: Codeunit "Confirm Management";
ExistingTransferLineQst: Label 'The component has already been assigned to the posted subcontracting transfer order %1.\\Do you want to continue?', Comment = '%1=Transfer Order No';
begin
if ProdOrderComponent."Subcontracting Type" <> "Subcontracting Type"::Transfer then
exit;

TransferShipLine.SetRange("Prod. Order No.", ProdOrderComponent."Prod. Order No.");
TransferShipLine.SetRange("Prod. Order Line No.", ProdOrderComponent."Prod. Order Line No.");
TransferShipLine.SetRange("Prod. Order Comp. Line No.", ProdOrderComponent."Line No.");
TransferShipLine.SetRange("Item No.", ProdOrderComponent."Item No.");
if not TransferShipLine.IsEmpty() then begin
TransferShipLine.SetLoadFields(SystemId);
TransferShipLine.FindFirst();
if not ConfirmMgt.GetResponse(StrSubstNo(ExistingTransferLineQst, TransferShipLine."Document No.")) then
TransferShipmentLine.SetRange("Prod. Order No.", ProdOrderComponent."Prod. Order No.");
TransferShipmentLine.SetRange("Prod. Order Line No.", ProdOrderComponent."Prod. Order Line No.");
TransferShipmentLine.SetRange("Prod. Order Comp. Line No.", ProdOrderComponent."Line No.");
TransferShipmentLine.SetRange("Item No.", ProdOrderComponent."Item No.");
if not TransferShipmentLine.IsEmpty() then begin
TransferShipmentLine.SetLoadFields(SystemId);
TransferShipmentLine.FindFirst();
if not ConfirmManagement.GetResponse(StrSubstNo(ExistingTransferLineQst, TransferShipmentLine."Document No.")) then
Error('');
end;
end;
Expand Down Expand Up @@ -240,10 +240,10 @@ codeunit 99001524 "Subc. Prod. Order Comp. Ext."
local procedure HandleRoutingLinkCodeValidation(var ProdOrderComponent: Record "Prod. Order Component"; var xProdOrderComponent: Record "Prod. Order Component")
var
ProdOrderLine: Record "Prod. Order Line";
ProdOrderRtngLine: Record "Prod. Order Routing Line";
SKU: Record "Stockkeeping Unit";
ProdOrderRoutingLine: Record "Prod. Order Routing Line";
StockkeepingUnit: Record "Stockkeeping Unit";
Vendor: Record Vendor;
GetPlanningParameters: Codeunit "Planning-Get Parameters";
PlanningGetParameters: Codeunit "Planning-Get Parameters";
SubcontractingManagement: Codeunit "Subcontracting Management";
begin
if ProdOrderComponent."Subcontracting Type" = ProdOrderComponent."Subcontracting Type"::Transfer then
Expand All @@ -252,16 +252,16 @@ codeunit 99001524 "Subc. Prod. Order Comp. Ext."
ProdOrderLine.SetLoadFields("Routing No.", "Routing Reference No.", "Item No.", "Variant Code", "Location Code");
ProdOrderLine.Get(ProdOrderComponent.Status, ProdOrderComponent."Prod. Order No.", ProdOrderComponent."Prod. Order Line No.");
if ProdOrderComponent."Routing Link Code" <> '' then begin
ProdOrderRtngLine.SetRange(Status, ProdOrderComponent.Status);
ProdOrderRtngLine.SetRange("Prod. Order No.", ProdOrderComponent."Prod. Order No.");
ProdOrderRtngLine.SetRange("Routing No.", ProdOrderLine."Routing No.");
ProdOrderRtngLine.SetRange("Routing Reference No.", ProdOrderLine."Routing Reference No.");
ProdOrderRtngLine.SetRange("Routing Link Code", ProdOrderComponent."Routing Link Code");
if ProdOrderRtngLine.FindFirst() then begin
ProdOrderComponent."Due Date" := ProdOrderRtngLine."Starting Date";
ProdOrderComponent."Due Time" := ProdOrderRtngLine."Starting Time";
if (ProdOrderRtngLine.Type = ProdOrderRtngLine.Type::"Work Center") then
if SubcontractingManagement.GetSubcontractor(ProdOrderRtngLine."No.", Vendor) then
ProdOrderRoutingLine.SetRange(Status, ProdOrderComponent.Status);
ProdOrderRoutingLine.SetRange("Prod. Order No.", ProdOrderComponent."Prod. Order No.");
ProdOrderRoutingLine.SetRange("Routing No.", ProdOrderLine."Routing No.");
ProdOrderRoutingLine.SetRange("Routing Reference No.", ProdOrderLine."Routing Reference No.");
ProdOrderRoutingLine.SetRange("Routing Link Code", ProdOrderComponent."Routing Link Code");
if ProdOrderRoutingLine.FindFirst() then begin
ProdOrderComponent."Due Date" := ProdOrderRoutingLine."Starting Date";
ProdOrderComponent."Due Time" := ProdOrderRoutingLine."Starting Time";
if (ProdOrderRoutingLine.Type = ProdOrderRoutingLine.Type::"Work Center") then
if SubcontractingManagement.GetSubcontractor(ProdOrderRoutingLine."No.", Vendor) then
SubcontractingManagement.ChangeLocation_OnProdOrderComponent(ProdOrderComponent, Vendor."Subcontr. Location Code", ProdOrderComponent."Orig. Location Code", ProdOrderComponent."Orig. Bin Code");
end;
end else
Expand All @@ -274,12 +274,12 @@ codeunit 99001524 "Subc. Prod. Order Comp. Ext."
ProdOrderComponent."Orig. Bin Code" := '';
end;
end else begin
GetPlanningParameters.AtSKU(
SKU,
PlanningGetParameters.AtSKU(
StockkeepingUnit,
ProdOrderLine."Item No.",
ProdOrderLine."Variant Code",
ProdOrderLine."Location Code");
ProdOrderComponent.Validate("Location Code", SKU."Components at Location");
ProdOrderComponent.Validate("Location Code", StockkeepingUnit."Components at Location");
end;
end;

Expand Down
Loading
Loading