[Shopify] Item Attributes as Product Options

src/Apps/W1/Shopify/App/src/Base/Tables/ShpfyShop.Table.al

@@ -5,6 +5,7 @@
 
 namespace Microsoft.Integration.Shopify;
 
+using Microsoft.Inventory.Item.Attribute;
 using Microsoft.Finance.Currency;
 using Microsoft.Finance.GeneralLedger.Account;
 using Microsoft.Finance.GeneralLedger.Setup;
@@ -300,6 +301,9 @@ table 30102 "Shpfy Shop"
 
             trigger OnValidate()
             begin
+                if "UoM as Variant" then
+                    VerifyNoItemAttributesAsOptions();
+
                 if "UoM as Variant" and ("Option Name for UoM" = '') then
                     "Option Name for UoM" := 'Unit of Measure';
             end;
@@ -1090,4 +1094,14 @@ table 30102 "Shpfy Shop"
     end;
 #pragma warning restore AL0432
 #endif
+
+    local procedure VerifyNoItemAttributesAsOptions()
+    var
+        ItemAttribute: Record "Item Attribute";
+        UoMVariantUnavailableErr: Label 'UoM as Variant is unavailable due to existing Item Attributes marked as “As Option” which are utilized for Shopify Product Options.';
+    begin
+        ItemAttribute.SetRange("Shpfy Incl. in Product Sync", "Shpfy Incl. in Product Sync"::"As Option");
+        if not ItemAttribute.IsEmpty() then
+            Error(UoMVariantUnavailableErr);
+    end;
 }

src/Apps/W1/Shopify/App/src/Products/Codeunits/ShpfyCreateItemAsVariant.Codeunit.al

@@ -34,21 +34,30 @@ codeunit 30343 "Shpfy Create Item As Variant"
     internal procedure CreateVariantFromItem(var Item: Record "Item")
     var
         TempShopifyVariant: Record "Shpfy Variant" temporary;
+        ProductExport: Codeunit "Shpfy Product Export";
+        VariantOptionTok: Label 'Variant', Locked = true;
+        TitleOptionTok: Label 'Title', Locked = true;
     begin
         if Item.SystemId = ShopifyProduct."Item SystemId" then
             exit;
 
         CreateProduct.CreateTempShopifyVariantFromItem(Item, TempShopifyVariant);
         TempShopifyVariant.Title := Item."No.";
 
-        if not ShopifyProduct."Has Variants" and (OptionName = 'Title') then begin
+        if not ShopifyProduct."Has Variants" and (OptionName = TitleOptionTok) then begin
             // Shopify automatically deletes the default variant (Title) when adding a new one so first we need to update the default variant to have a different name (Variant)
-            UpdateProductOption('Variant');
-            TempShopifyVariant."Option 1 Name" := 'Variant';
+            UpdateProductOption(VariantOptionTok);
+            TempShopifyVariant."Option 1 Name" := VariantOptionTok;
         end else
             TempShopifyVariant."Option 1 Name" := CopyStr(OptionName, 1, MaxStrLen(TempShopifyVariant."Option 1 Name"));
         TempShopifyVariant."Option 1 Value" := Item."No.";
 
+
+        if ShopifyProduct."Has Variants" and (OptionName <> VariantOptionTok) then begin
+            ProductExport.SetShop(Shop);
+            ProductExport.ValidateItemAttributesAsProductOptionsForNewVariant(TempShopifyVariant, Item, '', ShopifyProduct.Id);
+        end;
+
         Events.OnAfterCreateTempShopifyVariant(Item, TempShopifyVariant);
         TempShopifyVariant.Modify();
 
@@ -67,17 +76,13 @@ codeunit 30343 "Shpfy Create Item As Variant"
     var
         CommunicationMgt: Codeunit "Shpfy Communication Mgt.";
         Options: Dictionary of [Text, Text];
-        MultipleOptionsErr: Label 'The product has more than one option. Items cannot be added as variants to a product with multiple options.';
         UOMAsVariantEnabledErr: Label 'Items cannot be added as variants to a product with the "%1" setting enabled for this store.', Comment = '%1 - UoM as Variant field caption';
     begin
         if Shop."UoM as Variant" then
             Error(UOMAsVariantEnabledErr, Shop.FieldCaption("UoM as Variant"));
 
         Options := ProductApi.GetProductOptions(ShopifyProduct.Id);
 
-        if Options.Count > 1 then
-            Error(MultipleOptionsErr);
-
         OptionId := CommunicationMgt.GetIdOfGId(Options.Keys.Get(1));
         OptionName := Options.Values.Get(1);
     end;

src/Apps/W1/Shopify/App/src/Products/Codeunits/ShpfyCreateProduct.Codeunit.al

@@ -57,6 +57,9 @@ codeunit 30174 "Shpfy Create Product"
         TempShopifyVariant: Record "Shpfy Variant" temporary;
         TempShopifyTag: Record "Shpfy Tag" temporary;
     begin
+        if not ProductExport.CheckItemAttributesCompatibleForProductOptions(Item) then
+            exit;
+
         CreateTempProduct(Item, TempShopifyProduct, TempShopifyVariant, TempShopifyTag);
         if not VariantApi.FindShopifyProductVariant(TempShopifyProduct, TempShopifyVariant) then
             ProductId := ProductApi.CreateProduct(TempShopifyProduct, TempShopifyVariant, TempShopifyTag)
@@ -164,6 +167,7 @@ codeunit 30174 "Shpfy Create Product"
             end else
                 CreateTempShopifyVariantFromItem(Item, TempShopifyVariant);
 
+        ProductExport.FillProductOptionsForShopifyVariants(Item, TempShopifyVariant, TempShopifyProduct);
         TempShopifyProduct.Insert(false);
         Events.OnAfterCreateTempShopifyProduct(Item, TempShopifyProduct, TempShopifyVariant, TempShopifyTag);
     end;