Skip to content

bugs/Bug-617062-27.x-Filters on Create Documents function #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DhavalMore88 wants to merge 1 commit into
base: releases/27.x
Choose a base branch
from
+33 −19
Open

bugs/Bug-617062-27.x-Filters on Create Documents function #6258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions src/Apps/W1/Subscription Billing/App/Billing/Codeunits/CreateBillingDocuments.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,12 @@ codeunit 8060 "Create Billing Documents"
trigger OnRun()
var
BillingLine: Record "Billing Line";
PartnerFilter: Text;
ShowNotification: Boolean;
begin
BillingLine.Copy(Rec);
PartnerFilter := BillingLine.GetFilter(Partner);
ShowNotification := PartnerFilter <> BillingLine.GetFilters();
BillingLine.Reset();
BillingLine.SetFilter(Partner, PartnerFilter);
BillingLine.SetRange("Document Type", Enum::"Rec. Billing Document Type"::None);
if CreateContractInvoice then
BillingLine.SetRange("Billing Template Code", '');
CreateBillingDocuments(BillingLine);
if ShowNotification and (not CreateContractInvoice) then
ShowFiltersIgnoredNotification();
end;

local procedure CreateBillingDocuments(var BillingLine: Record "Billing Line")
Expand Down Expand Up @@ -1036,17 +1028,6 @@ codeunit 8060 "Create Billing Documents"
OnAfterIsNewHeaderNeededPerContract(CreateNewHeader, TempBillingLine, PreviousSubContractNo);
end;

local procedure ShowFiltersIgnoredNotification()
var
FiltersIgnoredNotification: Notification;
FiltersIgnoredMsg: Label 'You have set filters on the Recurring Billing page. The filters were ignored to maintain data consistency.';
begin
FiltersIgnoredNotification.Message(FiltersIgnoredMsg);
FiltersIgnoredNotification.Scope := NotificationScope::LocalScope;
FiltersIgnoredNotification.Send();
end;


internal procedure ErrorIfItemUnitOfMeasureCodeDoesNotExist(ItemNo: Code[20]; ServiceObject: Record "Subscription Header")
var
ItemUnitOfMeasure: Record "Item Unit of Measure";
Expand Down
33 changes: 33 additions & 0 deletions src/Apps/W1/Subscription Billing/Test/Billing/RecurringBillingTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ codeunit 139688 "Recurring Billing Test"
RecurringBillingPage: TestPage "Recurring Billing";
IsPartnerVendor: Boolean;
PostDocuments: Boolean;
DocumentNoShouldBeEmptyErr: Label 'Document No. should be empty for the first contract';

#region Tests

Expand Down Expand Up @@ -1451,6 +1452,32 @@ codeunit 139688 "Recurring Billing Test"
Assert.AreEqual("Sales Document Type"::"Credit Memo", BillingLine.GetSalesDocumentTypeForContractNo(), 'Sales Document Type is not calculated correctly for Credit Memo.');
end;

[Test]
[HandlerFunctions('CreateBillingDocsCustomerPageHandlerwithoutPost,ExchangeRateSelectionModalPageHandler,MessageHandler,BillingTemplateModalPageHandler')]
procedure CreateCustomerDocumentForSelectedContract()
begin
// [SCENARIO] otherwise, all billing lines will not be included in the document which will lead to wrong invoices and corrupted billing lines
Initialize();

// [GIVEN] Create Recurring Billing Page setup for Customer
RecurringBillingPageSetupForCustomer();

// [WHEN] Filter billing lines to exclude the last line and create/post documents
RecurringBillingPage.OpenEdit();
RecurringBillingPage.BillingTemplateField.Lookup();
PostDocuments := true;
RecurringBillingPage.CreateBillingProposalAction.Invoke();
RecurringBillingPage.Filter.SetFilter("Subscription Contract No.", CustomerContract2."No.");
RecurringBillingPage.CreateDocuments.Invoke();
Commit();

// [THEN] Only billing lines for the selected contract should be Created document.
BillingLine.Reset();
BillingLine.SetRange("Subscription Contract No.", CustomerContract."No.");
BillingLine.FindLast();
Assert.AreEqual('', BillingLine."Document No.", DocumentNoShouldBeEmptyErr);
end;

#endregion Tests

#region Procedures
Expand Down Expand Up @@ -1808,6 +1835,12 @@ codeunit 139688 "Recurring Billing Test"
ExchangeRateSelectionPage.OK().Invoke();
end;

[ModalPageHandler]
procedure CreateBillingDocsCustomerPageHandlerwithoutPost(var CreateBillingDocsCustomerPage: TestPage "Create Customer Billing Docs")
begin
CreateBillingDocsCustomerPage.OK().Invoke();
end;

[MessageHandler]
procedure MessageHandler(Message: Text[1024])
begin
Expand Down