Anjagraw/typing indicator

[anjalinitd]

Fixes #

Changelog Entry

Added a tag attribute for from object for typing indicator.

Description

• BotFramework-webchat-adapter sends from object as part of typing indicator activity which is mapped to typing object in Botframeork-webchat. Added a new tag in adapter as well as webchat to pass tag to receiver side to indicate sender is typing in public/Internal panel. (We have a single adapter for two react webchat's one is public other is internal to distinguish between the two we need tag params)

Design

Specific Changes

• Added a tag attribute for typing object in api/hooks
• Mapped to tag for from object for any incoming_activity for typing indicator

-

• I have added tests and executed them locally
• I have updated CHANGELOG.md
• I have updated documentation

Review Checklist

This section is for contributors to review your work.

• Accessibility reviewed (tab order, content readability, alt text, color contrast)
• Browser and platform compatibilities reviewed
• CSS styles reviewed (minimal rules, no z-index)
• Documents reviewed (docs, samples, live demo)
• Internationalization reviewed (strings, unit formatting)
• package.json and package-lock.json reviewed
• Security reviewed (no data URIs, check for nonce leak)
• Tests reviewed (coverage, legitimacy)

[compulim]

Direct Line activity schema does not contain from.tag field, https://github.com/microsoft/botframework-sdk/blob/master/specs/botframework-activity/botframework-activity.md#from. So, we can't retrieve tag value from the from property.

We can consider retrieving/saving channelData to the structure returned by useActiveTyping.

Please fill in the PR form. You can look for other PRs to get an idea of details we want to have. This is critical for us. If a future regression happens (it do!), the details in the PR form will help us to understand how this feature should work and why we added it in first place.

[anjalinitd]

Direct Line activity schema does not contain from.tag field, https://github.com/microsoft/botframework-sdk/blob/master/specs/botframework-activity/botframework-activity.md#from. So, we can't retrieve tag value from the from property. -> From object comes from botframework-webchat-adapter as per my understanding and then we map in webchat. We have a PR to update tag for from object in adapter side as well. I have tested this and it's working fine. Can updated the read me file: microsoft/botframework-webchat-chat-adapter#49

We can consider retrieving/saving channelData to the structure returned by useActiveTyping.

Please fill in the PR form. You can look for other PRs to get an idea of details we want to have. This is critical for us. If a future regression happens (it do!), the details in the PR form will help us to understand how this feature should work and why we added it in first place.