Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements telemetry validation functionality for Spring feature management, adding support for validating telemetry events generated during feature flag evaluations.
Key changes:
- Added telemetry result model and validation support to test cases
- Created new telemetry validation tests with logging infrastructure
- Updated Spring Boot and feature management library versions
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ValidationTestCase.java | Added telemetry field and corresponding getter/setter methods |
| TelemetryResult.java | New model class to represent telemetry event data |
| ValidationTestsApplicationTests.java | Enhanced with telemetry validation logic and logging event verification |
| BasicTelemetryTests.java | New test class specifically for telemetry validation with Logback appender setup |
| pom.xml | Updated Spring Boot (3.3.3 → 3.5.5) and feature management library (5.17.0 → 6.0.0-beta.2) versions |
| Multiple test files | Updated method calls to include null listAppender parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...tion-tests/src/test/java/com/microsoft/validation_tests/ValidationTestsApplicationTests.java
Show resolved
Hide resolved
...ng/validation-tests/src/test/java/com/microsoft/validation_tests/models/TelemetryResult.java
Outdated
Show resolved
Hide resolved
…icrosoft/validation_tests/models/TelemetryResult.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
zhiyuanliang-ms
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.