Open
Conversation
- renames noise_test/Neighbor*.wav to noise_test/NeighborSpeaking*.wav to conform to the naming in noise_train directory - renames noise_train/AirportAnnouncement_11.wav to AirportAnnouncements_11.wav to conform to the other AirportAnnouncement noise files - the config value total_snrlevels is read as int instead of float in order to avoid rutime error in np.linspace(...) - strips the list of strings which is read from the config value noise_types_excluded in order to allow comma separated lists with spaces (as suggested in the documentation of the config file)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested improvements:
Rename some of the wav files to have a uniform naming
strip the elements of the config parameter noise_types_excluded in order to allow comma separated list with spaces between the elements
read the config parameter total_snrlevels as int in order to avoid exception in the function np.linspace(...)