Skip to content

Fix PowerShell detection and config issues on Windows 11 24H2 #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dids wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix PowerShell detection and config issues on Windows 11 24H2 #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions PsfLauncher/PsfPowershellScriptRunner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,21 @@ class PsfPowershellScriptRunner
wil::unique_hkey registryHandle;
LSTATUS createResult = RegCreateKeyExW(HKEY_LOCAL_MACHINE, L"SOFTWARE\\Microsoft\\PowerShell\\1", 0, nullptr, REG_OPTION_NON_VOLATILE, KEY_READ, nullptr, &registryHandle, nullptr);

// If key 1 exists, check if Install value exists - if not, treat it as if key doesn't exist
if (createResult == ERROR_SUCCESS)
{
DWORD valueFromRegistry = 0;
DWORD bufferSize = sizeof(DWORD);
DWORD type = REG_DWORD;
LSTATUS queryResult = RegQueryValueExW(registryHandle.get(), L"Install", nullptr, &type, reinterpret_cast<BYTE*>(&valueFromRegistry), &bufferSize);
if (queryResult == ERROR_FILE_NOT_FOUND)
{
// Install value missing, set an error to trigger fallback to key 3
createResult = ERROR_PATH_NOT_FOUND;
registryHandle.reset();
}
}

if (createResult == ERROR_FILE_NOT_FOUND)
{
// If the key cannot be found, powershell is not installed
Expand Down