Block at compile time invalid arguments to Distinct#2857
Open
CarlosFigueiraMSFT wants to merge 3 commits intomainfrom
Open
Block at compile time invalid arguments to Distinct#2857CarlosFigueiraMSFT wants to merge 3 commits intomainfrom
CarlosFigueiraMSFT wants to merge 3 commits intomainfrom
Conversation
Contributor
|
✅ No public API change. |
Contributor
|
✅ No public API change. |
Ananya-Gupta24
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Distinct function only works for primitive values, but currently this error only happens at runtime. This PR adds a compile-time check to ensure that only primitive values are passed to the Distinct function. The check is done under the PFxV1 flag, since this currently works in Power Apps (although there are many bugs on the implementation).