Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a rendering event lifecycle issue in the Power BI AsterPlot visual and bumps the visual/package versions accordingly, with an accompanying changelog entry.
Changes:
- Fix rendering event sequencing in
update()and ensurerenderingFinishedis called on early-return paths. - Bump visual/package versions to
1.8.2.0and add a1.8.2changelog entry. - Refresh
package-lock.json(large transitive dependency update).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/visual.ts |
Adjusts renderingStarted/renderingFinished calls to better match actual render lifecycle and early returns. |
pbiviz.json |
Bumps visual display/version to 1.8.2.0. |
package.json |
Bumps npm package version to 1.8.2.0. |
package-lock.json |
Updates lockfile version fields and many transitive packages (tooling + runtime). |
CHANGELOG.md |
Adds release notes for 1.8.2 describing the rendering events fix. |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+229
to
233
| this.events.renderingStarted(options); | ||
| try { | ||
| if (!this.areValidOptions(options)) { | ||
| this.events.renderingFinished(options); | ||
| return; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.