Skip to content

<xloctime>: Fix time_get::do_get to parse a literal % #6140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mirion-dev wants to merge 4 commits into
base: main
Choose a base branch
from
+27 −0
Open

<xloctime>: Fix time_get::do_get to parse a literal % #6140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9aea925
Fix `time_get::do_get` to parse a literal `%`
mirion-dev Mar 4, 2026
82db724
Use CRLF instead of LF
mirion-dev Mar 4, 2026
60e5e9e
Add eofbit check for GH_006130
mirion-dev Mar 4, 2026
f297242
Move GH-6130 tests to Dev11-0836436
mirion-dev Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions stl/inc/xloctime
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,14 @@ protected:
}
break;

case '%':
if (_First == _Last || _Ctype_fac.narrow(*_First) != '%') {
_State |= ios_base::failbit;
} else {
++_First;
}
break;

default:
_State |= ios_base::failbit; // unknown specifier
break;
Expand Down
19 changes: 19 additions & 0 deletions tests/std/tests/Dev11_0836436_get_time/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ void test_gh_2618();
void test_gh_2848();
void test_gh_4820();
void test_gh_4882();
void test_gh_6130();

int main() {
assert(read_hour("12 AM") == 0);
Expand Down Expand Up @@ -160,6 +161,7 @@ int main() {
test_gh_2848();
test_gh_4820();
test_gh_4882();
test_gh_6130();
}

typedef istreambuf_iterator<char> Iter;
Expand Down Expand Up @@ -961,3 +963,20 @@ void test_gh_4882() {
fieldValidation(testData.field, testData.hi, testData.fmt);
}
}

void test_gh_6130() {
// GH-6130 <xloctime>: time_get::do_get doesn't parse a literal %
{
tm t{};
stringstream ss{"%"};
ss >> get_time(&t, "%%");
assert(!ss.fail() && ss.eof());
}

{
tm t{};
stringstream ss{"% "};
ss >> get_time(&t, "%%");
assert(!ss.fail() && ss.tellg() == 1);
}
}