Toolset update: MSVC Compiler 19.51.36122, CUDA 13.2#6157
Open
StephanTLavavej wants to merge 39 commits intomicrosoft:mainfrom
Open
Toolset update: MSVC Compiler 19.51.36122, CUDA 13.2#6157StephanTLavavej wants to merge 39 commits intomicrosoft:mainfrom
StephanTLavavej wants to merge 39 commits intomicrosoft:mainfrom
Conversation
Internal toolset is still 19.50.
Users have occasionally misused this, it's outdated for C++26, and it isn't a huge time-saver anyways.
If the compiler or WinSDK version checks fail, we should point to the README's centralized explanation of the VS Installer and `vcvarsall.bat` options.
…ckout. Deleting and recreating tmpDir is essentially cleaning, so we don't need to adjust the displayName. The checkout doesn't use tmpDir, so we can do this in any order. This will avoid displaying an extremely boring step in Azure Pipelines.
MSVC warning C4296: '<': expression is always false CUDA warning 186-D: pointless comparison of unsigned integer with zero
This was introduced by GH 5662 on 2025-08-08.
Just initialize the return value with `{}` to avoid garbage.
Use the name `_Tm` (instead of the previous `_Time`) for consistency with other returns.
Avoids host compiler error C2760: syntax error: '}' was unexpected here; expected 'expression'
I'm adding test coverage for this.
No test coverage necessary; the whole issue was that static_assert(false) was previously an instant error.
I'm adding test coverage for this.
I'm adding test coverage for this.
I'm adding test coverage for this.
I'm adding test coverage for this.
…025-12-12. Including the 4th and final workaround, which appears to have been fixed by later changes.
…on 2026-02-02. P1004R2_constexpr_vector still needs 2 workarounds, filed GH 6155 for followup.
…er test or care about.
``` C:\Program Files\Microsoft Visual Studio\18\Insiders\VC\Tools\MSVC\14.50.35717\bin\Hostx64\x64>dir | rg "EspXEngine|CppCoreCheck" 01/21/2026 03:15 PM 1,343,008 CppCoreCheck.dll 01/21/2026 03:15 PM 3,117,128 EspXEngine.dll C:\Program Files\Microsoft Visual Studio\18\Insiders\VC\Tools\MSVC\14.51.36122\bin\Hostx64\x64>dir | rg "EspXEngine|CppCoreCheck" 03/10/2026 11:27 AM 4,054,048 EspXEngine.dll ```
…tead of handwritten logic. Drop the "TRANSITION, Evil Extension" comment because all usage of is_permissive is inherently TRANSITION. De Morgan the condition to clarify its behavior.
Cite GH 5061 and GH 5097 so we don't attempt to remove this without proper care. Use "workaround / no workaround" for clarity.
The paragraph number changed, but the content was otherwise identical.
We're never going to mess with this again.
And VSO-2826400 was fixed by MSVC-PR-717544 on 2026-03-13.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Commits
vcvarsall.batoptions.<chrono>: Use designated aggregate initialization when returningtm#5662 on 2025-08-08. Just initialize the return value with{}to avoid garbage. Use the name_Tm(instead of the previous_Time) for consistency with other returns. Avoids host compiler error C2760: syntax error: '}' was unexpected here; expected 'expression'P1004R2_constexpr_vector: Report MSVCconstexprerror affectingstd::construct_atarray support #6155 for followup./Zabug, which we no longer test or care about.__restrictusage for CUDA #5061 and Don't use__restrict__for CUDA #5097 so we don't attempt to remove this without proper care. Use "workaround / no workaround" for clarity.basic_format_arg()workaround._STATIC_CALL_OPERATOR=>static,_CONST_CALL_OPERATOR=> nothingSTL-ASan-CI passed.