Upgrade to Eslint9

eslint.config.mjs

@@ -0,0 +1,63 @@
+import { defineConfig } from "eslint/config";
+import react from "eslint-plugin-react";
+import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import globals from "globals";
+import tsParser from "@typescript-eslint/parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default defineConfig([{
+    extends: compat.extends("eslint:recommended", "plugin:@typescript-eslint/eslint-recommended"),
+
+    plugins: {
+        react,
+        "@typescript-eslint": typescriptEslint,
+    },
+
+    languageOptions: {
+        globals: {
+            ...globals.browser,
+            ...globals.mocha,
+            ...globals.node,
+            Atomics: "readonly",
+            SharedArrayBuffer: "readonly",
+        },
+
+        parser: tsParser,
+        ecmaVersion: 2018,
+        sourceType: "module",
+
+        parserOptions: {
+            ecmaFeatures: {
+                jsx: true,
+            },
+        },
+    },
+
+    rules: {
+        "comma-dangle": ["error", "always-multiline"],
+        "no-inner-declarations": ["off"],
+        "no-mixed-spaces-and-tabs": ["off"],
+        "no-prototype-builtins": ["off"],
+
+        indent: ["error", 4, {
+            SwitchCase: 1,
+        }],
+
+        "no-unused-vars": ["off"],
+        "prefer-spread": ["off"],
+        "quote-props": ["error", "consistent-as-needed"],
+        quotes: ["error", "single"],
+        semi: ["error", "always"],
+    },
+}]);

extensions/azdata-sanddance/package.json

@@ -92,7 +92,7 @@
         }
     },
     "scripts": {
-        "eslint": "eslint -c ../../.eslintrc.json --fix ./src/**/*.ts*",
+        "eslint": "eslint -c ../../eslint.config.mjs --fix ./src/**/*.ts*",
         "clean": "rimraf ./resources/*.*",
         "vscode:prepublish": "webpack --mode production",
         "webpack": "webpack --mode development",

extensions/azdata-sanddance/src/azdata.proposed.d.ts

@@ -1078,8 +1078,8 @@ declare module 'azdata' {
 	    private dim: Dimension;
 
 	    constructor(
-			private container: HTMLElement, options: IInsightOptions = defaultOptions,
-			@IInstantiationService private _instantiationService: IInstantiationService
+			container: HTMLElement, options: IInsightOptions = defaultOptions,
+			_instantiationService: IInstantiationService
 		);
 
 	    public layout(dim: Dimension);

extensions/common-backend/package.json

@@ -5,7 +5,7 @@
   "description": "Common backend code for vscode-extension based projects",
   "main": "dist/es6/index.js",
   "scripts": {
-    "eslint": "eslint -c ../../.eslintrc.json --fix ./src/**/*.ts*",
+    "eslint": "eslint -c ../../eslint.config.mjs --fix ./src/**/*.ts*",
     "build:07": "tsc -p ."
   },
   "repository": {

extensions/common-frontend/package.json

@@ -5,7 +5,7 @@
   "description": "Common frontend code for vscode-extension based projects",
   "main": "index.js",
   "scripts": {
-    "eslint": "eslint -c ../../.eslintrc.json --fix ./src/**/*.ts*",
+    "eslint": "eslint -c ../../eslint.config.mjs --fix ./src/**/*.ts*",
     "build-css": "sass ./src/css/app.scss ./dist/app.css",
     "build-ui": "tsc -p .",
     "build:07": "npm run build-css && npm run build-ui",

extensions/vscode-sanddance/package.json

@@ -84,7 +84,7 @@
         }
     },
     "scripts": {
-        "eslint": "eslint -c ../../.eslintrc.json --fix ./src/**/*.ts*",
+        "eslint": "eslint -c ../../eslint.config.mjs --fix ./src/**/*.ts*",
         "clean": "rimraf ./resources/*.*",
         "vscode:prepublish": "webpack --mode production",
         "webpack": "webpack --mode development",