Skip to content

Implement keysinuse forking handlers for 1.9 #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mamckee wants to merge 11 commits into
base: scossl-1.9
Choose a base branch
from
Open

Implement keysinuse forking handlers for 1.9 #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7c3754f
Support forking processes for KeysInUse (#146)
mamckee Sep 19, 2025
7e2e48f
Safely reinitialize global locks
jasjivsingh-corp Dec 12, 2025
3401a25
Rename functions
mamckee Jan 22, 2026
7f5cbff
Remove reference file
mamckee Feb 4, 2026
113f5c6
Block keysinuse startup if parent process is multithreaded
mamckee Feb 4, 2026
9864c03
Address PR comments to make callbacks safer
mamckee Feb 4, 2026
0a9409e
Additional cleanup safety
mamckee Feb 5, 2026
068e4e0
PR comments
mamckee Feb 5, 2026
47fd94d
PR comments
mamckee Feb 5, 2026
af8a7a0
Update SymCryptProvider/src/p_scossl_keysinuse.c
mamckee Feb 5, 2026
e9f647e
PR comments
mamckee Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions SymCryptProvider/src/p_scossl_ecc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ SCOSSL_STATUS p_scossl_ecc_get_encoded_public_key(const SCOSSL_ECC_KEY_CTX *keyC

if (scError != SYMCRYPT_NO_ERROR)
{
SCOSSL_PROV_LOG_SYMCRYPT_ERROR("SymCryptEckeyGetValue failed", scError);
SCOSSL_PROV_LOG_SYMCRYPT_ERROR("SymCryptEckeyGetValue failed", scError);
goto cleanup;
}

Expand Down Expand Up @@ -131,8 +131,8 @@ void p_scossl_ecc_init_keysinuse(SCOSSL_ECC_KEY_CTX *keyCtx)
{
// Initialize keysinuse for private keys. Generated keys are
// ignored to avoid noise from ephemeral keys.
PBYTE pbPublicKey;
SIZE_T cbPublicKey;
PBYTE pbPublicKey = NULL;
SIZE_T cbPublicKey = 0;

// KeysInUse related errors shouldn't surface to caller
ERR_set_mark();
Expand Down
Loading