.NET: Increase credential timeout for Integration Tests#4472
Open
westey-m wants to merge 6 commits intomicrosoft:mainfrom
Open
.NET: Increase credential timeout for Integration Tests#4472westey-m wants to merge 6 commits intomicrosoft:mainfrom
westey-m wants to merge 6 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates .NET integration tests to use a shared Azure CLI credential helper with a longer process timeout, reducing CI flakiness from AzureCliCredential initialization.
Changes:
- Add
Shared.IntegrationTests.TestCredentialshelper that creates anAzureCliCredentialwith a 60sProcessTimeout. - Wire the helper into several integration test projects and update call sites to use it.
- Extend MSBuild shared-code injection (
Shared.props) and solution items to include the new shared helper.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests.csproj | Enables injection of the shared Azure credentials helper into this test project. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Framework/IntegrationTest.cs | Switches workflow test harness to use TestCredentials.CreateAzureCliCredential(). |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/AzureAgentProviderTest.cs | Uses shared credential helper for provider construction. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Agents/VisionAgentProvider.cs | Uses shared credential helper for AIProjectClient. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Agents/TestAgentProvider.cs | Uses shared credential helper for AIProjectClient. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Agents/PoemAgentProvider.cs | Uses shared credential helper for AIProjectClient. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Agents/MathChatAgentProvider.cs | Uses shared credential helper for AIProjectClient. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Agents/MarketingAgentProvider.cs | Uses shared credential helper for AIProjectClient. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Agents/FunctionToolAgentProvider.cs | Uses shared credential helper for AIProjectClient. |
| dotnet/tests/Microsoft.Agents.AI.FoundryMemory.IntegrationTests/Microsoft.Agents.AI.FoundryMemory.IntegrationTests.csproj | Enables injection of the shared Azure credentials helper into this test project. |
| dotnet/tests/Microsoft.Agents.AI.FoundryMemory.IntegrationTests/FoundryMemoryProviderTests.cs | Uses shared credential helper for AIProjectClient. |
| dotnet/tests/Microsoft.Agents.AI.DurableTask.IntegrationTests/TestHelper.cs | Uses shared credential helper for AzureOpenAIClient when authenticating via Azure CLI. |
| dotnet/tests/Microsoft.Agents.AI.DurableTask.IntegrationTests/Microsoft.Agents.AI.DurableTask.IntegrationTests.csproj | Enables injection of the shared Azure credentials helper into this test project. |
| dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentFixture.cs | Uses shared credential helper for PersistentAgentsClient. |
| dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistent.IntegrationTests.csproj | Enables injection of the shared Azure credentials helper into this test project. |
| dotnet/tests/AzureAI.IntegrationTests/AzureAI.IntegrationTests.csproj | Enables injection of the shared Azure credentials helper into this test project. |
| dotnet/tests/AzureAI.IntegrationTests/AIProjectClientFixture.cs | Uses shared credential helper for AIProjectClient. |
| dotnet/src/Shared/IntegrationTestsAzureCredentials/TestCredentials.cs | Introduces shared helper creating AzureCliCredential with longer process timeout. |
| dotnet/src/Shared/IntegrationTestsAzureCredentials/README.md | Documents how to enable the shared credentials helper via MSBuild property. |
| dotnet/eng/MSBuild/Shared.props | Adds a new conditional Compile include to inject the shared credentials helper. |
| dotnet/agent-framework-dotnet.slnx | Adds solution items for the new shared credentials helper folder/files. |
dotnet/tests/AzureAI.IntegrationTests/AIProjectClientFixture.cs
Outdated
Show resolved
Hide resolved
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentFixture.cs
Show resolved
Hide resolved
...ests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Framework/IntegrationTest.cs
Show resolved
Hide resolved
dotnet/src/Shared/IntegrationTestsAzureCredentials/TestAzureCliCredentials.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Integration tests are often failing with a timeout on
new AzureCliCredential().Description
Contribution Checklist