feat: add input_schema to Tool protocol to match ecosystem convention#22
Open
momuno wants to merge 1 commit intomicrosoft:mainfrom
Open
feat: add input_schema to Tool protocol to match ecosystem convention#22momuno wants to merge 1 commit intomicrosoft:mainfrom
momuno wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Every official tool module (tool-bash, tool-filesystem, tool-todo, etc.) already implements input_schema as a @Property returning a JSON Schema dict, but the kernel's Tool Protocol in interfaces.py did not require it. This created a gap between the formal contract and what all real tools do. Additionally, TOOL_CONTRACT.md referenced a get_schema() method that no real module implements. This commit: - Adds input_schema property to the Tool Protocol in interfaces.py - Updates TOOL_CONTRACT.md to use input_schema property throughout - Adds input_schema validation check in tool.py - Adds behavioral and structural tests for input_schema - Updates MockTool classes in test_validation.py to include input_schema - Adds input_schema to the MyTool example in README.md Backward compatible: all existing tool modules already implement this property. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every official tool module (tool-bash, tool-filesystem, tool-todo, etc.) already implements input_schema as a @Property returning a JSON Schema dict, but the kernel's Tool Protocol in interfaces.py did not require it. This created a gap between the formal contract and what all real tools do.
Additionally, TOOL_CONTRACT.md referenced a get_schema() method that no real module implements.
This commit:
Backward compatible: all existing tool modules already implement this property.
🤖 Generated with Amplifier