feat: inject _instance_name from provider name field into config#23
Draft
ekg wants to merge 1 commit intomicrosoft:mainfrom
Draft
feat: inject _instance_name from provider name field into config#23ekg wants to merge 1 commit intomicrosoft:mainfrom
ekg wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When the provider config has a 'name' field (from settings.yaml), inject it as '_instance_name' into the provider config before loading. This enables named provider instances where the same module (e.g., provider-openai) can be used for multiple services (openrouter, deepseek, etc.) with different names. Companion to PR microsoft#17 on provider-openai which added _instance_name support for named provider instances. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the provider config has a 'name' field (from settings.yaml), inject it as '_instance_name' into the provider config before loading. This enables named provider instances where the same module (e.g., provider-openai) can be used for multiple services (openrouter, deepseek, etc.) with different names.
Context
Companion to PR #17 on provider-openai which added _instance_name support for named provider instances.
Test plan
🤖 Generated with Amplifier