Add on_child_initialized callback to PreparedBundle.spawn()#94
Open
michaeljabbour wants to merge 1 commit intomicrosoft:mainfrom
Open
Add on_child_initialized callback to PreparedBundle.spawn()#94michaeljabbour wants to merge 1 commit intomicrosoft:mainfrom
michaeljabbour wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Adds optional on_child_initialized callback parameter that is invoked after child_session.initialize() completes but before child_session.execute(instruction) begins. This enables apps to inject hooks (streaming, observability, approval) on child sessions without inlining spawn internals. The callback receives the initialized AmplifierSession, allowing clean injection of child-specific configuration while maintaining API stability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional
on_child_initializedcallback parameter toPreparedBundle.spawn()that is invoked after child session initialization but before execution begins.This enables apps (like Kepler) to inject hooks (streaming, observability, approval) on child sessions without inlining spawn internals or creating maintenance burden as foundation evolves.
Changes
on_child_initialized: Any = Noneparameter tospawn()signaturechild_session.initialize()and before instruction injectionAmplifierSessionfor clean hook injectionImpact
Enables clean elimination of ~60 lines of inlined spawn logic in desktop apps that need child-session hooks. Any app requiring post-initialization, pre-execution injection gets the same benefit.
Example