Skip to content

fix: Update defaultAction for networkAcls for aifcu based on enablePrivateNetworking parameter #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harsh-Microsoft wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: Update defaultAction for networkAcls for aifcu based on enablePrivateNetworking parameter #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,7 @@ module avmAiServices_cu 'br/public:avm/res/cognitive-services/account:0.13.2' =
enableTelemetry: enableTelemetry
networkAcls: {
bypass: 'AzureServices'
defaultAction: 'Allow' // Always allow for AI Services
defaultAction: (enablePrivateNetworking) ? 'Deny' : 'Allow'
}
roleAssignments: [
{
Expand Down
6 changes: 3 additions & 3 deletions infra/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.40.2.10011",
"templateHash": "4821257159531769907"
"templateHash": "16588330151933076270"
},
"name": "Content Processing Solution Accelerator",
"description": "Bicep template to deploy the Content Processing Solution Accelerator with AVM compliance."
Expand Down Expand Up @@ -40925,9 +40925,9 @@
"dependsOn": [
"avmContainerApp",
"avmManagedIdentity",
"[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').openAI)]",
"[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').cognitiveServices)]",
"[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').aiServices)]",
"[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').openAI)]",
"[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').contentUnderstanding)]",
"logAnalyticsWorkspace",
"virtualNetwork"
Expand Down Expand Up @@ -40981,7 +40981,7 @@
"networkAcls": {
"value": {
"bypass": "AzureServices",
"defaultAction": "Allow"
"defaultAction": "[if(parameters('enablePrivateNetworking'), 'Deny', 'Allow')]"
}
},
"roleAssignments": {
Expand Down