Add weak_ptr to NetworkInformation in SetupNetDetect #1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is this required to be included in the release? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a weak pointer to NetworkInformation in the SetupNetDetect method to prevent potential retain cycles when capturing this in Objective-C blocks. This is a defensive programming practice that ensures the NetworkInformation object can be properly deallocated even if the callback outlives the object.
Key Changes:
- Added
weak_ptrinitialization fromshared_from_this()before setting up the network path monitor callback
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Yes, because the weak_this variable is referenced below. |
ThomsonTan
reviewed
Jan 6, 2026
ThomsonTan
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add weak_ptr to NetworkInformation in SetupNetDetect