This repository was archived by the owner on Dec 15, 2023. It is now read-only.
Use https URL for accessing NPM registry data#174
Merged
orta merged 2 commits intomicrosoft:masterfrom Dec 25, 2021
Merged
Conversation
Currently dts-gen is broken as it attempts to access the registry by http, which results in a 301 to https. This fixes that error by using https in the first place.
Contributor
Author
|
Related: #172 attempts to fix this by following the 301. Both of these could be merged so we don't have an unnecessary redirect in the first place and to provide future robustness. |
pimterry
approved these changes
Dec 1, 2021
pimterry
left a comment
pimterry
left a comment
There was a problem hiding this comment.
I was just about to open a PR to do exactly the same thing 👍
Contributor
|
Agree, thanks folks |
|
@orta Is there a plan to release a new version with the fix? |
12 tasks
Contributor
Author
|
@RyanCavanaugh are you able to cut a new release of dts-gen to fix this? |
|
10 months old Bugs... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently dts-gen is broken as it attempts to access the registry by http, which results in a 301 to https. This fixes that error by using https in the first place.