Merged
Conversation
halspang
reviewed
Dec 15, 2025
Member
halspang
left a comment
There was a problem hiding this comment.
Is there anyway to test or verify that this doesn't leave the system in a bad state? Even a test where we call shutdownNow and then recreate the connection and complete a request?
Contributor
Author
After spending much too long attempting to make this test, I think we are actually implicitly doing this for every test in the |
halspang
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where a customer is running into an error when attempting to start a new orchestration:
Previous channel ManagedChannelImpl{logId=57, target=localhost:4001} was not shutdown properly!!!The stack trace indicates that this occurs when attempting to build a new
managedSideCarChannelin theDurableTaskGrpcClient. It appears that the previousmanagedSidecarChannelwas not disposed properly in a call toclose(). This can happen since we do nothing if the channel is not successfully terminated via a graceful call toshutdown()within thetimeout(5 seconds). It can also happen if anInterruptedExceptionis thrown, since we don't attempt any shutdown in that case.To fix this, this PR initiates a forceful shutdown if the graceful shutdown fails in the timeframe. It also initiates a forceful shutdown in the case of an
InterruptedException(but manually sets the thread's state to "interrupted" so that we do not lose this information).Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information