fix: set instanceId on ActivityResponse in failure path#122
Merged
YunchuWang merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
The activity execution error handler in TaskHubGrpcWorker was not setting the instanceId field on the ActivityResponse when an activity throws an exception. The success path correctly called res.setInstanceid(instanceId), but the catch block omitted it. This deviates from the .NET SDK behavior, which always sets InstanceId on the ActivityResponse regardless of outcome. The missing field could cause issues with sidecar response routing or logging for failed activities. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Fixes an inconsistency in the worker’s activity completion reporting so that ActivityResponse.instanceId is always populated, matching .NET SDK behavior and preventing missing-instance routing/logging issues on failure.
Changes:
- Set
ActivityResponse.instanceIdin the activity execution failure path inTaskHubGrpcWorker. - Add unit coverage to verify
instanceIdis set for activity success,Errorfailures, and non-Errorthrows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/durabletask-js/src/worker/task-hub-grpc-worker.ts | Ensures ActivityResponse.instanceId is set in the catch/failure branch. |
| packages/durabletask-js/test/worker-activity-response.spec.ts | Adds tests asserting instanceId is present on ActivityResponse in success and failure scenarios. |
kaibocai
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The activity execution error handler in TaskHubGrpcWorker was not setting the instanceId field on the ActivityResponse when an activity throws an exception. The success path correctly called res.setInstanceid(instanceId), but the catch block omitted it.
This deviates from the .NET SDK behavior, which always sets InstanceId on the ActivityResponse regardless of outcome. The missing field could cause issues with sidecar response routing or logging for failed activities.
Summary
What changed?
Why is this change needed?
Issues / work items
Project checklist
CHANGELOG.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
AI verification (required if AI was used):
Testing
Automated tests
Manual validation (only if runtime/behavior changed)
1.
2.
3.
Notes for reviewers