Skip to content

Fix detection playbook inaccuracies in daily-code-review agent #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
torosent merged 2 commits into from
Mar 4, 2026
+3 −3
Merged

Fix detection playbook inaccuracies in daily-code-review agent #129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e72640
Initial plan
Copilot Mar 4, 2026
68a2075
Apply review feedback to daily-code-review agent detection playbook
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/agents/daily-code-review.agent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ Flag any function/file exceeding these limits:

### Error Handling
- **Empty catch blocks:** `catch (e) {}` — silently swallows errors
- **Missing error cause:** `throw new Error(msg)` without `{ cause }` loses context (ES2022 supports `{ cause: origErr }`)
- **Missing error cause when wrapping:** When rethrowing or wrapping an existing error, preserve it via `throw new Error(msg, { cause: err })` instead of dropping the original error.
- **Broad catch:** Giant try/catch wrapping entire functions instead of targeting fallible ops
- **Error type check by name:** `e.constructor.name === 'TypeError'` instead of `instanceof`

Expand Down Expand Up @@ -304,7 +304,7 @@ primary mission — prioritize bugs and missing tests.
| Manual `for` loop building/filtering array | `.map()` / `.filter()` / `.find()` / `.reduce()` |
| `.then().then().catch()` chains | `async`/`await` with try/catch |
| `Object.assign({}, a, b)` | `{ ...a, ...b }` (spread) |
| `JSON.parse(JSON.stringify(obj))` | `structuredClone(obj)` |
| `JSON.parse(JSON.stringify(obj))` on JSON-serializable data | `structuredClone(obj)` — note: `structuredClone` throws on non-serializable values (e.g. functions, symbols); only substitute when data is known to be JSON-serializable |
| `obj.hasOwnProperty(k)` | `Object.hasOwn(obj, k)` |
| `arr[arr.length - 1]` | `arr.at(-1)` |
| `for (k in obj)` (includes prototype keys) | `for (const k of Object.keys(obj))` |
Expand All @@ -317,13 +317,13 @@ primary mission — prioritize bugs and missing tests.
| String concatenation `'Hello ' + name` | Template literal `` `Hello ${name}` `` |
| `function(x) { return x * 2; }` | `x => x * 2` (arrow) |
| `{ x: x, y: y }` | `{ x, y }` (shorthand property) |
| `this._secret` convention | `#secret` (private field, ES2022) |
| Implicit `any` on public API | Add explicit type annotations |

### Do NOT Flag (out of scope for this repo)
- CommonJS `require()` → ESM `import` (repo intentionally uses CommonJS)
- React/Next.js patterns (not in this codebase)
- ES2024+ features (`Object.groupBy`, `Set.intersection`, `Promise.withResolvers`) — repo targets ES2022
- Private field naming (`this._secret` vs `#secret`); repo uses `_underscorePrefixed` per `.github/copilot-instructions.md`

---

Expand Down