Skip to content

fix: update daily code review agent to require tracking issues before… #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YunchuWang merged 1 commit into from
Mar 4, 2026
+22 −3
Merged

fix: update daily code review agent to require tracking issues before… #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions .github/agents/daily-code-review.agent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,27 @@ From all findings, select the **single most impactful** based on:
- You can't write a meaningful test for it
- It touches generated code or third-party dependencies

## Step 4: Create PR (1 Maximum)
## Step 4: Create Tracking Issue (MANDATORY — Before Any PR)

For each selected finding, create a **separate PR** with:
Before creating a PR, create a **GitHub issue** to track the finding:

### Issue Content

**Title:** `[copilot-finds] <Category>: <Clear one-line description>`

**Body must include:**
1. **Problem** — What's wrong and why it matters (with file/line references)
2. **Root Cause** — Why this happens
3. **Proposed Fix** — High-level description of what the PR will change
4. **Impact** — Severity and which scenarios are affected

**Labels:** Apply the `copilot-finds` label to the issue.

**Important:** Record the issue number — you will reference it in the PR.

## Step 5: Create PR (1 Maximum)

For the selected finding, create a **separate PR** linked to the tracking issue:

### Branch Naming
`copilot-finds/<category>/<short-description>` where category is `bug`, `test`, or `improve`.
Expand All @@ -125,6 +143,7 @@ Example: `copilot-finds/bug/fix-unhandled-promise-rejection`
3. **Fix** — What the PR changes and why this approach
4. **Testing** — What new tests were added and what they verify
5. **Risk** — What could go wrong with this change (be honest)
6. **Tracking Issue** — `Fixes #<issue-number>` (links to the tracking issue created in Step 4)

### Code Changes
- Fix the actual problem
Expand All @@ -143,7 +162,7 @@ Example: `copilot-finds/bug/fix-unhandled-promise-rejection`
### Labels
Apply the `copilot-finds` label to every PR.

## Step 5: Quality Gates (MANDATORY — Do This Before Opening Each PR)
## Step 6: Quality Gates (MANDATORY — Do This Before Opening Each PR)

Before opening each PR, you MUST:

Expand Down
Loading