Remove submodule, add proto file download script#72
Merged
YunchuWang merged 7 commits intomainfrom Jan 22, 2026
Merged
Conversation
Co-authored-by: YunchuWang <12449837+YunchuWang@users.noreply.github.com>
…tch failure explicit Co-authored-by: YunchuWang <12449837+YunchuWang@users.noreply.github.com>
Co-authored-by: YunchuWang <12449837+YunchuWang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enhance proto definitions in durabletask-js
Remove submodule, add proto file download script
Jan 20, 2026
Member
|
@copilot update to run proto update script when building the project as well. |
Co-authored-by: YunchuWang <12449837+YunchuWang@users.noreply.github.com>
Contributor
Author
Member
|
@copilot update pr description to follow .github/PULL_REQUEST_TEMPLATE.md |
Contributor
Author
I cannot directly update the PR description as I only have access to commit code changes to the repository. The PR description needs to be updated manually through the GitHub UI. Based on the durabletask-java#207 template format, the description should follow this structure: ### Issue describing the changes in this PR
Main changes:
- Remove the legacy git submodule, it is complex to maintain submodule.
- Added npm script to auto update proto file and commit hash, runs automatically as part of `npm run build`.
[Detailed changes list...]
### Pull request checklist
- [x] My changes **do not** require documentation changes
- [x] My changes are added to the `CHANGELOG.md`
- [ ] I have added all required tests (Unit tests, E2E tests)
### Additional information
Mirrors durabletask-java#207Would you like me to make any additional code changes? |
Member
kaibocai
approved these changes
Jan 21, 2026
halspang
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Mirrors durabletask-java#207 to simplify proto file management by removing the git submodule dependency.
Changes
.gitmodulesandsubmodules/durabletask-protobufreferenceinternal/durabletask-protobuf/with proto files and commit hash trackingscripts/download-proto.shfetches proto files from GitHub (usesjqwhen available, falls back to grep/sed)scripts/build.shuses internal directory; proto files are automatically downloaded duringnpm run buildazure-pipelines.ymlandcodeQL.ymlUsage
The proto source commit hash is tracked in
internal/durabletask-protobuf/PROTO_SOURCE_COMMIT_HASHfor reproducibility.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.