fix(workflows): remove release-please skip guard that prevents tag creation#511
Conversation
…eation - remove commit-message guard from release-please job in main.yml - update docs/architecture/workflows.md to reflect v4 native handling - remove stale '(skipped on release commits)' note from jobs table Fixes #510 🐛 - Generated by Copilot
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 85.34% 85.32% -0.03%
==========================================
Files 23 23
Lines 4476 4476
==========================================
- Hits 3820 3819 -1
- Misses 656 657 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the release-please job was being skipped on release-merge commits, which prevented tag and GitHub Release creation on merge to main. It removes the now-unnecessary guard (given release-please v4 behavior) and updates workflow documentation accordingly.
Changes:
- Removed the commit-message
ifguard from therelease-pleasejob in the main branch workflow so releases/tags are created on release PR merges. - Updated workflow architecture documentation to reflect release-please v4 behavior and removed the outdated “skipped on release commits” note.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/main.yml |
Ensures release-please runs on release PR merge commits so tags/releases get created immediately. |
docs/architecture/workflows.md |
Updates workflow documentation to match the new (and correct) release-please behavior. |
- replace em dash with period per writing-style guidance - hyphenate chore-type commits for grammar clarity - fix table column alignment to pass table-format check 🔧 - Generated by Copilot
| | Job | Purpose | Dependencies | | ||
| |---------------------------|--------------------------------|------------------------------| | ||
| | spell-check | Post-merge spelling validation | None | | ||
| | markdown-lint | Post-merge markdown validation | None | | ||
| | table-format | Post-merge table validation | None | | ||
| | dependency-pinning-scan | Security pinning check | None | | ||
| | pester-tests | PowerShell unit tests | None | | ||
| | release-please | Automated release management | All validation jobs | | ||
| | extension-package-release | Build release VSIX | release-please (conditional) | | ||
| | attest-and-upload | Sign and upload VSIX | extension-package-release | |
There was a problem hiding this comment.
The “Main Branch Jobs” table no longer matches .github/workflows/main.yml: the workflow also includes plugin-package-release, upload-plugin-packages, and publish-release jobs, but they are not documented here. Please add the missing jobs (and ideally reflect them in the pipeline diagram/description) so the docs stay accurate.
🤖 I have created a release *beep* *boop* --- ## [2.3.0](hve-core-v2.2.0...hve-core-v2.3.0) (2026-02-13) ### ✨ Features * **agents:** add GitHub backlog management pipeline ([#448](#448)) ([2b4d123](2b4d123)) * **docs:** define inactivity closure policies for issues and PRs ([#452](#452)) ([5e710fd](5e710fd)) * **extension:** implement collection-based plugin distribution system ([#439](#439)) ([3156d98](3156d98)) * **instructions:** replace EVEN/ODD hardcoding with runtime milestone discovery protocol ([#486](#486)) ([ae95eb2](ae95eb2)) * **plugin:** support Copilot CLI plugin generation from collection manifests ([#496](#496)) ([e6cee85](e6cee85)) * **scripts:** enhance on-create.sh to install actionlint and PowerShell modules ([#500](#500)) ([67585f5](67585f5)) ### 🐛 Bug Fixes * **docs:** replace broken relative link with inline code reference ([#465](#465)) ([8133b36](8133b36)) * **instructions:** prevent local-only paths from leaking into GitHub issues ([#489](#489)) ([497d2fe](497d2fe)) * **workflows:** prevent release-please infinite loop on main branch ([#470](#470)) ([134bdd6](134bdd6)) * **workflows:** remove release-please skip guard that prevents tag creation ([#511](#511)) ([5e53271](5e53271)) ### 📚 Documentation * **agents:** add GitHub Backlog Manager documentation and agent catalog ([#503](#503)) ([5e818ce](5e818ce)) * align CONTRIBUTING.md with docs/contributing/ guides ([#445](#445)) ([73ef6aa](73ef6aa)) ### ♻️ Refactoring * **scripts:** refactor dev-tools and lib scripts to use CIHelpers module ([#482](#482)) ([fdf9145](fdf9145)) * **scripts:** standardize PowerShell entry point guard pattern ([#477](#477)) ([6b84a8e](6b84a8e)) ### 🔧 Maintenance * **config:** standardize action mappings in artifact-retention.yml ([#487](#487)) ([7927db2](7927db2)) * **deps-dev:** bump cspell from 9.6.2 to 9.6.4 in the npm-dependencies group ([#461](#461)) ([c788095](c788095)) * **deps:** bump actions/setup-python from 5.1.1 to 6.2.0 in the github-actions group ([#462](#462)) ([69ef3c9](69ef3c9)) * **security:** add SBOM artifact retention policy ([#479](#479)) ([8031557](8031557)), closes [#453](#453) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: hve-core-release-please[bot] <254602402+hve-core-release-please[bot]@users.noreply.github.com>
Description
Removed a commit-message guard on the release-please job in the main branch workflow that prevented tag and release creation when release PR merges landed. Release-please v4 handles
chore-type commits natively, making the guard unnecessary and harmful.ifcondition on therelease-pleasejob inmain.ymlthat skipped execution when the head commit started withchore(main): release, allowingcreateReleases()to run on release PR mergesdocs/architecture/workflows.mdto explain that release-please v4 handles chore commits natively and removed the stale "(skipped on release commits)" note from the Main Branch Jobs tableRelated Issue(s)
Fixes #510
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md)Other:
.ps1,.sh,.py)Testing
npm run lint:mdwith 0 errors on changed filesnpx cspellwith 0 issues on changed filesactionlintChecklist
Required Checks
Required Automated Checks
The following validation commands must pass before merging:
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run lint:md-linksnpm run lint:psSecurity Considerations
Additional Notes
Previously validated in
Azure-Samples/azure-nvidia-robotics-reference-architecture(PR #175 / issue #174). The guard was originally added for release-please v3 loop prevention, which v4 handles internally by classifyingchorecommits as non-releasable.🔧 - Generated by Copilot