Open
Conversation
jmaxson-ms
requested review from
helenkzhang,
mslukebo,
trgibeau and
xj-ms
as code owners
xj-ms
reviewed
Nov 25, 2024
| .Throws<ArgumentNullException>(); | ||
|
|
||
| var sut = new FileBackedPluginRegistry(this.registryRoot, fakeSerializer.Object); | ||
| var sut = new FileBackedPluginRegistry(this.registryRoot, fakeSerializer.Object, Logger.Create); |
Contributor
There was a problem hiding this comment.
We can extract a method for creating FileBackedPluginRegistry that will make modifying the constructor much easier in the future. Also we can avoid running the actual logging logic using Mock<ILooger>
Contributor
There was a problem hiding this comment.
+1, I prefer having a CreateSut() method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PluginsDiscoveryOrchestrator was using Logger.Create despite having stored a logger factory.
Several other classes had constructors that default to Logger.Create as a logger factory. Rather than keeping these around, the tests that used these now pass in Logger.Create.