-
Notifications
You must be signed in to change notification settings - Fork 339
Fix MSSentinelSearch environment name and connection check in AzureSearchDriver #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
14
commits into
main
Choose a base branch
from
copilot/fix-azure-search-driver-connection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d override query method Co-authored-by: ianhelle <13070017+ianhelle@users.noreply.github.com>
…ation Co-authored-by: ianhelle <13070017+ianhelle@users.noreply.github.com>
Co-authored-by: ianhelle <13070017+ianhelle@users.noreply.github.com>
Co-authored-by: ianhelle <13070017+ianhelle@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MSSentinelSearch data provider connection issue with AzureSearchDriver
Fix MSSentinelSearch environment and connection handling in AzureSearchDriver
Jan 21, 2026
Copilot
AI
changed the title
Fix MSSentinelSearch environment and connection handling in AzureSearchDriver
Fix MSSentinelSearch environment name and connection check in AzureSearchDriver
Jan 21, 2026
ianhelle
approved these changes
Jan 22, 2026
FlorianBracq
requested changes
Jan 31, 2026
- Add drop_duplicates(subset=['query']) before merge in get_whois_df to prevent row multiplication from duplicate whois results - Change net_df fixture scope from module to function for test isolation with random sampling - Add autouse fixture to clear LRU caches (get_whois_info, _whois_lookup) between tests to prevent state leakage
Contributor
|
Thx for the review @FlorianBracq - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AzureSearchDriverinheritedEFFECTIVE_ENV="MSSentinel"from its parentAzureMonitorDriver, causing the QueryProvider to report the wrong environment name. Additionally, the inheritedquery()method checked for_query_client(used by parent) instead of_auth_header(used by this driver), causing "Workspace not connected" errors even after successful connection.Changes
__init__: SetEFFECTIVE_ENVto"MSSentinelSearch"after parent initialization"MSSentinelSearch"in supported environments tuple_ensure_connected()helper to check_auth_header is not None_ensure_connected()instead of parent's_query_clientcheckExample
Original prompt
This section details on the original issue you should resolve
<issue_title>[Bug]: New experimenal MSSentinelSearch data provider doesn't correctly use the AzureSearchDriver</issue_title>
<issue_description>Describe the bug
The
MSSentinelSearchquery provider / data environment seems to get confused between using the MSSentinel vs MSSentinelSearch data environments and fails to correctly connect the AzureSearchDriver.To Reproduce
Steps to reproduce the behavior:
Ianhelle/az monitor search driver 2025 02 05 #825 included in main.
Expected behavior
AzureSearchDriver is connected and used with the corresponding MSSentinelSearch data environment.
Screenshots and/or Traceback
Environment (please complete the following information):
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.