Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| void Telemetry::LogSessionCreationEnd(uint32_t session_id, | ||
| const common::Status& status) const { |
Contributor
There was a problem hiding this comment.
Suggested change
| const common::Status& status) const { | |
| const common::Status& status) const { |
| } | ||
|
|
||
| void Telemetry::LogRegisterEpLibraryWithLibPath(const std::string& registration_name, | ||
| const std::string& lib_path) const { |
Contributor
There was a problem hiding this comment.
Suggested change
| const std::string& lib_path) const { | |
| const std::string& lib_path) const { |
| } | ||
|
|
||
| void Telemetry::LogRegisterEpLibraryEnd(const std::string& registration_name, | ||
| const common::Status& status) const { |
Contributor
There was a problem hiding this comment.
Suggested change
| const common::Status& status) const { | |
| const common::Status& status) const { |
| virtual void LogModelLoadEnd(uint32_t session_id, const common::Status& status) const; | ||
|
|
||
| virtual void LogSessionCreationEnd(uint32_t session_id, | ||
| const common::Status& status) const; |
Contributor
There was a problem hiding this comment.
Suggested change
| const common::Status& status) const; | |
| const common::Status& status) const; |
| virtual void LogRunStart(uint32_t session_id) const; | ||
|
|
||
| virtual void LogRegisterEpLibraryWithLibPath(const std::string& registration_name, | ||
| const std::string& lib_path) const; |
Contributor
There was a problem hiding this comment.
Suggested change
| const std::string& lib_path) const; | |
| const std::string& lib_path) const; |
| } | ||
|
|
||
| void WindowsTelemetry::LogRegisterEpLibraryWithLibPath(const std::string& registration_name, | ||
| const std::string& lib_path) const { |
Contributor
There was a problem hiding this comment.
Suggested change
| const std::string& lib_path) const { | |
| const std::string& lib_path) const { |
| } | ||
|
|
||
| void WindowsTelemetry::LogRegisterEpLibraryEnd(const std::string& registration_name, | ||
| const common::Status& status) const { |
Contributor
There was a problem hiding this comment.
Suggested change
| const common::Status& status) const { | |
| const common::Status& status) const { |
| void LogModelLoadEnd(uint32_t session_id, const common::Status& status) const override; | ||
|
|
||
| void LogSessionCreationEnd(uint32_t session_id, | ||
| const common::Status& status) const override; |
Contributor
There was a problem hiding this comment.
Suggested change
| const common::Status& status) const override; | |
| const common::Status& status) const override; |
| void LogRegisterEpLibraryStart(const std::string& registration_name) const override; | ||
|
|
||
| void LogRegisterEpLibraryEnd(const std::string& registration_name, | ||
| const common::Status& status) const override; |
Contributor
There was a problem hiding this comment.
Suggested change
| const common::Status& status) const override; | |
| const common::Status& status) const override; |
Comment on lines
+980
to
+981
| constexpr static long long kRuntimePerfInitialInterval = 2 * 1000 * 1000; // 2 seconds in (us) | ||
| constexpr static long long kRuntimePerfMaxInterval = 1000 * 1000 * 60 * 10; // 10 minutes in (us) |
Contributor
There was a problem hiding this comment.
Suggested change
| constexpr static long long kRuntimePerfInitialInterval = 2 * 1000 * 1000; // 2 seconds in (us) | |
| constexpr static long long kRuntimePerfMaxInterval = 1000 * 1000 * 60 * 10; // 10 minutes in (us) | |
| constexpr static long long kRuntimePerfInitialInterval = 2 * 1000 * 1000; // 2 seconds in (us) | |
| constexpr static long long kRuntimePerfMaxInterval = 1000 * 1000 * 60 * 10; // 10 minutes in (us) |
dabhattimsft
requested review from
angelser,
bmehta001,
skottmckay and
yuslepukhin
adrastogi
reviewed
Feb 17, 2026
| } | ||
| ORT_TRY { | ||
| const Env& env = Env::Default(); | ||
| env.GetTelemetryProvider().LogModelLoadStart(session_id_); |
Contributor
There was a problem hiding this comment.
Non-blocking: this is more general than the changes here, but I guess a byproduct of the Start / Stop telemetry pattern is that the Stop call is not universally guaranteed to fire due to e.g., early returns from some of those ORT_RETURN macros. We should have scope guards (or whatever the equivalent pattern is in the code base). I can file an issue and try to fix this later.
Author
There was a problem hiding this comment.
Yep, I thought about that. My thinking was to have those instances end up as timeout in MC state-machine.
Contributor
Where does that happen? Having trouble finding it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ModelLoadStart/End - InferenceSession::LoadWithLoader, InferenceSession::LoadOrtModelWithLoader
SessionCreationEnd - InferenceSession::Initialize
RegisterEpLibraryWithLibPath, RegisterEpLibraryStart/End - Environment::RegisterExecutionProviderLibrary
Update: RuntimePerf event now logs status as well and is triggered more frequently with exponential backoff and any time !retval.IsOK().
It is also now triggered from ~InferenceSession() to log data in the tail.
Motivation and Context
To better measure health