Skip to content

fix: waitForCondition should not call predicate after it returned true#1721

Merged
yury-s merged 1 commit intomicrosoft:mainfrom
yury-s:waitForCondition-idempotent
Dec 19, 2024
Merged

fix: waitForCondition should not call predicate after it returned true#1721
yury-s merged 1 commit intomicrosoft:mainfrom
yury-s:waitForCondition-idempotent

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented Dec 19, 2024

Previously it would fail with this exception:

java.lang.AssertionError
	at com.microsoft.playwright.impl.WaitableRace.get(WaitableRace.java:40)
	at com.microsoft.playwright.impl.ChannelOwner.runUntil(ChannelOwner.java:132)
	at com.microsoft.playwright.impl.BrowserContextImpl.waitForCondition(BrowserContextImpl.java:670)
	at com.microsoft.playwright.BrowserContext.waitForCondition(BrowserContext.java:1545)

@yury-s yury-s merged commit 42d0203 into microsoft:main Dec 19, 2024
12 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s @pavelfeldman

Comments