fix(webSocketRoute): resolve URL against baseURL#1722
Merged
Conversation
mxschmitt
force-pushed
the
resolve-url
branch
from
2eea1bf to
7cb13ce
Compare
yury-s
reviewed
Dec 28, 2024
playwright/src/main/java/com/microsoft/playwright/impl/UrlMatcher.java
Outdated
Show resolved
Hide resolved
mxschmitt
force-pushed
the
resolve-url
branch
from
7cb13ce to
b96d153
Compare
mxschmitt
commented
Jan 27, 2025
| if (glob != null) { | ||
| return Pattern.compile(globToRegex(resolveUrl(baseURL, glob))).matcher(value).find(); | ||
| if (!glob.startsWith("*")) { | ||
| // Allow http(s) baseURL to match ws(s) urls. |
Contributor
Author
There was a problem hiding this comment.
mxschmitt
force-pushed
the
resolve-url
branch
from
b96d153 to
abc12f6
Compare
dgozman
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
URLis not able to parse aws://url, onlyURIis able to.This applies this upstream logic to Java.
Relates #1715
Extracted from #1717