Conversation
Skn0tt
changed the title
playwright/src/main/java/com/microsoft/playwright/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserTypeImpl.java
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserTypeImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/LocatorAssertionsImpl.java
Outdated
Show resolved
Hide resolved
| options.recordHarContent = null; | ||
| options.recordHarUrlFilter = null; | ||
| } else { | ||
| if (options.recordHarOmitContent != null) { |
There was a problem hiding this comment.
I dropped them accidentally! good catch. I added them back in.
There was a problem hiding this comment.
+1, I guess there are no tests for this 😄
playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java
Outdated
Show resolved
Hide resolved
| ExpectedTextValue expected = new ExpectedTextValue(); | ||
| expected.string = classname; | ||
| expectImpl("to.contain.class", expected, classname, "Locator expected to contain class", convertType(options, FrameExpectOptions.class)); | ||
| expectImpl("to.contain.class", expected, classname, "Locator expected to contain class", convertType(options, FrameExpectOptions.class), "Assert \"containsClass\""); |
There was a problem hiding this comment.
Maybe "assertThat().containsClass()" ?
There was a problem hiding this comment.
Dotnet uses Expect "ToContainClassAsync" - let's mirror that wording for now. https://github.com/microsoft/playwright-dotnet/blob/1320cc6d92eac27c68040ddf91206be12297989a/src/Playwright/Core/LocatorAssertions.cs#L151
| } | ||
|
|
||
| @Test | ||
| @DisabledIf(value="com.microsoft.playwright.TestBase#isChromium", disabledReason="skip") |
There was a problem hiding this comment.
Do we now support pdf in ff and wk?
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't see why it can't be tested on the client end even if the place where the error is thrown was moved to the server.
| options.recordHarContent = null; | ||
| options.recordHarUrlFilter = null; | ||
| } else { | ||
| if (options.recordHarOmitContent != null) { |
There was a problem hiding this comment.
+1, I guess there are no tests for this 😄
3 participants
No description provided.