Merged
Conversation
agg23
commented
Jun 20, 2025
playwright/_impl/_browser_type.py
Outdated
| params["clientCertificates"] = await to_client_certificates_protocol( | ||
| params["clientCertificates"] | ||
| ) | ||
| params["selectorEngines"] = self._playwright.selectors._selectorEngines |
Contributor
Author
There was a problem hiding this comment.
This is copied from _browser.py, with the changes being this line and below.
agg23
changed the title
agg23
requested review from
dgozman and
mxschmitt
and removed request for
mxschmitt
mxschmitt
previously requested changes
Jun 21, 2025
dgozman
approved these changes
Jun 24, 2025
Contributor
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
I'd like a follow up with an explicit timeout in each method, instead of a global "timeout calculator". It feels like that would be less magic and not so bad in terms of code.
dgozman
approved these changes
Jun 24, 2025
Michael-F-Bryan
added a commit
to multiversal-ventures/mvv-opentelemetry-instrumentation-playwright
that referenced
this pull request
Sep 22, 2025
…overed dynamically so we are always compatible with the current version of playwright This was introduced after playwright released a breaking change in a patch release - they removed the `timeout` argument from the `Frame.is_hidden()` method in microsoft/playwright-python#2892
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally mirrored microsoft/playwright-dotnet#3184, but due to the selector bug (microsoft/playwright#36227) causing half the Python tests to fail, the roll had to be made to include this change. Thus the roll is the entire roll to
1.53.1.Implements changes from microsoft/playwright#35888, microsoft/playwright#35969, and microsoft/playwright#35988, among others.
References #2818