Skip to content

fix: clamp setTimeout value to prevent negative timeout crash #39273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
veeceey wants to merge 4 commits into
base: main
Choose a base branch
from
+24 −7
Open

fix: clamp setTimeout value to prevent negative timeout crash #39273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
194046d
fix: clamp setTimeout value to prevent negative timeout crash
veeceey Feb 14, 2026
cee5af9
fix: skip timer entirely when no deadline is set
veeceey Feb 16, 2026
93d6e8e
fix: clamp deadline - monotonicTime() to zero in progress.ts and loca…
veeceey Feb 16, 2026
d9cf092
fix: skip timer entirely when deadline has already passed
veeceey Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions packages/playwright-core/src/server/progress.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,26 @@ export class ProgressController {

if (deadline) {
const timeoutError = new TimeoutError(`Timeout ${timeout}ms exceeded.`);
timer = setTimeout(() => {
// TODO: migrate this to "progress.disableTimeout()".
if (this.metadata.pauseStartTime && !this.metadata.pauseEndTime)
return;
const remaining = deadline - monotonicTime();
if (remaining <= 0) {
// Deadline already passed, fire immediately without scheduling a timer.
if (this._state === 'running') {
this._state = { error: timeoutError };
this._forceAbortPromise.reject(timeoutError);
this._controller.abort(timeoutError);
}
}, deadline - monotonicTime());
} else {
timer = setTimeout(() => {
// TODO: migrate this to "progress.disableTimeout()".
if (this.metadata.pauseStartTime && !this.metadata.pauseEndTime)
return;
if (this._state === 'running') {
this._state = { error: timeoutError };
this._forceAbortPromise.reject(timeoutError);
this._controller.abort(timeoutError);
}
}, remaining);
}
}

try {
Expand Down
11 changes: 9 additions & 2 deletions packages/playwright-core/src/utils/isomorphic/timeoutRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,16 @@ export async function raceAgainstDeadline<T>(cb: () => Promise<T>, deadline: num
return { result, timedOut: false };
}),
new Promise<{ timedOut: true }>(resolve => {
if (!deadline)
return;
const kMaxDeadline = 2147483647; // 2^31-1
const timeout = (deadline || kMaxDeadline) - monotonicTime();
timer = setTimeout(() => resolve({ timedOut: true }), timeout);
const timeout = deadline - monotonicTime();
if (timeout <= 0) {
// Deadline already passed, resolve immediately without scheduling a timer.
resolve({ timedOut: true });
return;
}
timer = setTimeout(() => resolve({ timedOut: true }), Math.min(timeout, kMaxDeadline));
Copy link
Member

@pavelfeldman pavelfeldman Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we agreed to not set timer at all. Here we are at risk of firing in 0ms.

Copy link
Author

@veeceey veeceey Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, clamping to 0 still fires the timer. Updated to check deadline - monotonicTime() <= 0 and resolve immediately with { timedOut: true } — no setTimeout at all when the deadline has already passed.

}),
]).finally(() => {
clearTimeout(timer);
Expand Down