Skip to content

fix(metro-config): fix asset URLs not being restored when targeting Windows #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tido64 merged 1 commit into from
Jan 27, 2026
Merged

fix(metro-config): fix asset URLs not being restored when targeting Windows #3940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-llamas-sip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rnx-kit/metro-config": patch
---

Fixed asset URLs not being restored when targeting Windows
14 changes: 13 additions & 1 deletion packages/metro-config/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,19 @@ function additionalConfig(projectRoot, inputConfig) {
];
} else {
const { restoreAssetURL } = require("./assetPlugins/escapeAssetURLs.js");
config.server = { rewriteRequestUrl: restoreAssetURL };
config.server = {
// Some platforms (notably Windows) still prefer `enhanceMiddleware` over
// `rewriteRequestUrl`. We need to set both to ensure asset URLs are
// properly restored.
enhanceMiddleware: (middleware) => {
/** @type {import("connect").NextHandleFunction} */
return (req, res, next) => {
req.url = restoreAssetURL(req.url ?? "");
return middleware(req, res, next);
};
},
rewriteRequestUrl: restoreAssetURL,
};

transformer.assetPlugins = [
require.resolve("./assetPlugins/escapeAssetURLs.js"),
Expand Down
Loading