Rename OnFailureActivity to OnSignInFailureActivity#364
Open
Rename OnFailureActivity to OnSignInFailureActivity#364
OnFailureActivity to OnSignInFailureActivity#364Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the built-in sign-in failure invoke handler to a more specific name to reduce the chance of future naming/namespace collisions, and updates the Graph sample’s sign-in failure user message to match the revised wording.
Changes:
- Renamed the default handler method from
OnFailureActivitytoOnSignInFailureActivity. - Updated the app constructor wiring to register the renamed handler for
OnSignInFailure(...). - Updated the Graph sample’s sign-in failure message text.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Samples/Samples.Graph/Program.cs | Updates the user-facing sign-in failure message string in the sample. |
| Libraries/Microsoft.Teams.Apps/AppRouting.cs | Renames the protected default signin/failure invoke handler method. |
| Libraries/Microsoft.Teams.Apps/App.cs | Updates default handler registration to use the renamed method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
heyitsaamir
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid the risk of future namespace collisions, rename
OnFailureActivitytoOnSignInFailureActivity.OnFailureActivitytoOnSignInFailureActivityto match naming convention & reduce risk of naming collisions