Skip to content

fix: downgrade expected token exchange failure logs from error to info #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heyitsaamir merged 3 commits into from
Mar 6, 2026
Merged

fix: downgrade expected token exchange failure logs from error to info #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c392ae7
fix: downgrade expected token exchange failure logs from error to info
heyitsaamir Mar 6, 2026
ffb41a9
test: remove logger level assertions from token exchange tests
heyitsaamir Mar 6, 2026
bdee0a3
fix: use local log variable and keep error level for non-HTTP exceptions
heyitsaamir Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions packages/apps/src/microsoft_teams/apps/app_oauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,19 +60,25 @@ async def sign_in_token_exchange(
self.event_emitter.emit("sign_in", SignInEvent(activity_ctx=ctx, token_response=token))
return None
except Exception as e:
ctx.logger.error(
f"Error exchanging token for user {activity.from_.id} in "
f"conversation {activity.conversation.id}: {e}"
)
if isinstance(e, HTTPStatusError):
status = e.response.status_code
if status not in (404, 400, 412):
log.error(
f"Error exchanging token for user {activity.from_.id} in "
f"conversation {activity.conversation.id}: {e}"
)
self.event_emitter.emit("error", ErrorEvent(error=e, context={"activity": activity}))
return InvokeResponse(status=status or 500)
ctx.logger.warning(
f"Unable to exchange token for user {activity.from_.id} in "
f"conversation {activity.conversation.id}: {e}"
)
log.info(
f"Unable to exchange token for user {activity.from_.id} in "
f"conversation {activity.conversation.id}: {e}"
)
else:
log.error(
f"Unable to exchange token for user {activity.from_.id} in "
f"conversation {activity.conversation.id}: {e}"
)
self.event_emitter.emit("error", ErrorEvent(error=e, context={"activity": activity}))
return InvokeResponse(
status=412,
body=TokenExchangeInvokeResponse(
Expand Down
9 changes: 4 additions & 5 deletions packages/apps/tests/test_app_oauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,6 @@ async def test_sign_in_token_exchange_http_error_404(self, oauth_handlers, mock_
# Verify no error event emitted for 404
oauth_handlers.event_emitter.emit.assert_not_called()

# Verify warning logged
mock_context.logger.warning.assert_called_once()

# Verify failure response
assert isinstance(result, InvokeResponse) and isinstance(result.body, TokenExchangeInvokeResponse)
assert result.status == 412
Expand Down Expand Up @@ -215,8 +212,10 @@ async def test_sign_in_token_exchange_generic_exception(

result = await oauth_handlers.sign_in_token_exchange(mock_context)

# Verify warning logged
mock_context.logger.warning.assert_called_once()
# Verify error event emitted for non-HTTP exceptions
oauth_handlers.event_emitter.emit.assert_called_once_with(
"error", ErrorEvent(error=generic_error, context={"activity": token_exchange_activity})
)

# Verify failure response
assert isinstance(result, InvokeResponse) and isinstance(result.body, TokenExchangeInvokeResponse)
Expand Down