Fix JWT validator issuer validation and audience matching#469
Open
heyitsaamir wants to merge 2 commits intomainfrom
Open
Fix JWT validator issuer validation and audience matching#469heyitsaamir wants to merge 2 commits intomainfrom
heyitsaamir wants to merge 2 commits intomainfrom
Conversation
- Fix validateIssuer treating {allowedTenantIds: undefined} as configured
validation (JSON.stringify hides undefined keys but `in` operator still
finds them). Now checks the actual value, not just key presence.
- Add api://botid-{clientId} to default audience list for bot token
validation.
- Add optional `audience` field to IJwtValidationOptions for custom
audience values beyond the defaults.
- Add applicationIdUri to AppOptions, matching webApplicationInfo.resource in the Teams app manifest - Wire through createEntraTokenValidator to JwtValidator.audience - Add tests for audience validation (default audiences, custom, rejection) - Add tests for issuer validation edge cases (empty object, undefined/empty allowedTenantIds) - Add tests for applicationIdUri in createEntraTokenValidator factory
Jesperholmbergmsft
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateIssuer: { allowedTenantIds: undefined }was incorrectly treated as configured validation.api://botid-{clientId}to default audience list for bot token validation since this is a really common, default value of the application id uri.audiencefield toIJwtValidationOptionsfor custom audience values beyond the defaults (clientId,api://clientId,api://botid-clientId).Test plan
api://botid-{clientId}audience are acceptedcreateEntraTokenValidatorwithout explicitallowedTenantIdsno longer rejects valid tokens