Support for custom configurations #2020
Conversation
DanielRosenwasser
left a comment
DanielRosenwasser
left a comment
There was a problem hiding this comment.
We haven't discussed this more broadly, but custom config specification has been a long-standing request with a lot of interest. The scope of implementing could grow a bit from what's here if we need something beyond a naive restart, but maybe this is good to start. I'll let others weigh in.
_extension/src/client.ts
Outdated
| this.outputChannel.appendLine(`Resolved to ${this.exe.path}`); | ||
|
|
||
| // Get pprofDir | ||
| // Get pprofDir |
There was a problem hiding this comment.
Switch this and every other TS line back to spaces
_extension/src/client.ts
Outdated
| { | ||
| ...this.clientOptions, | ||
| initializationOptions: { | ||
| customConfigFileName, |
There was a problem hiding this comment.
Rather than be part of initialization, we think this sort of thing would belong more on user preferences (see here.
Whether we just say "you need to restart the server" or we track this sort of thing on the server in some way is a bigger question.
There was a problem hiding this comment.
hey @DanielRosenwasser i've just made the changes to have it be included in user preferences and have tested it works - could you take another look please
|
I'm not sure what happened with your PRs, but can you keep the one you intend us to look at open and keep pushing to that one? |
|
ah sorry - i was rebasing PR's - i will close the previous PR and use this one instead |
johnnycheng0210
force-pushed
the
johnnyxc-tsgo-rebased-all-config
branch
2 times, most recently
from
56c19c5 to
7b164ac
Compare
johnnycheng0210
force-pushed
the
johnnyxc-tsgo-rebased-all-config
branch
from
7b164ac to
52ffc8e
Compare
3 participants
Follow up more up to date rebase of this #1636.
Address the feat request in this ticket, by allowing custom configs to be passed to the tsgo LSP.