This repository was archived by the owner on Feb 20, 2021. It is now read-only.
Added config option to enable/disable WebSockets#16
Open
vpiskunov wants to merge 1 commit intomicrosoftarchive:masterfrom
Open
Added config option to enable/disable WebSockets#16vpiskunov wants to merge 1 commit intomicrosoftarchive:masterfrom
vpiskunov wants to merge 1 commit intomicrosoftarchive:masterfrom
Conversation
Due to WebSockets being refused by the server, a workaround is to disable WSS by default, and enable only when needed & if it is working by passing 'websockets': true to the constructor when creating a new instance (see issue microsoftarchive#7)
|
@vpiskunov do you have your own distribution until and if this gets merged? |
Author
|
I have a forked repo with this patch applied, look at https://github.com/vpiskunov/wunderlist.js Let me know if you need anything else |
|
@vpiskunov could you compile the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to WebSockets being refused by the server, a workaround is to disable WSS by default, and enable only when needed & if it is working by passing 'sockets': true to the constructor when creating a new instance (see issue #7 )
NB: typo on commit comment, option name is 'sockets', not 'websockets'