ci: fix broken OpenAPI generation#1392
Merged
MIchaelMainer merged 16 commits intodevfrom Oct 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes OpenAPI generation that was broken in the previous dev merge to main. The changes enable OpenAPI files to be checked into the repository and introduce PR creation for reviewing OpenAPI changes before they are committed.
Key changes:
- Enhanced git-push-cleanmetadata.ps1 script to support PR creation workflow
- Added comprehensive logging and status checks throughout the process
- Implemented PR creation for OpenAPI files in the capture-openapi.yml pipeline
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/git-push-cleanmetadata.ps1 | Enhanced with PR creation support, improved logging, and better error handling |
| scripts/create-pull-request.ps1 | Fixed variable declaration order issue |
| .azure-pipelines/generation-templates/capture-openapi.yml | Added PR creation workflow and improved display names for clarity |
| .azure-pipelines/generation-templates/capture-metadata.yml | Updated to explicitly set CreatePR=False for CSDL metadata |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…crosoftgraph/MSGraph-SDK-Code-Generator into mmainer/fix-broken-generation
MIchaelMainer
commented
Oct 20, 2025
MIchaelMainer
commented
Oct 20, 2025
ramsessanchez
previously approved these changes
Oct 21, 2025
Collaborator
Author
|
We have successful OpenAPI changes pushed and PRs opened: We have an approval gate for OCE to review OpenAPI before we generate SDKs. See build 201145. |
MIchaelMainer
commented
Oct 23, 2025
gavinbarron
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We broke OpenAPI generation with our last dev merge to main.
The changes in this PR include:
Microsoft Reviewers: Open in CodeFlow