Dockerize setup #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename knn_classifier to classifier * remove deprecated file * support changing classifier type * add classifier type flag * update readme * linting
* rename knn_classifier to classifier * remove deprecated file * support changing classifier type * add classifier type flag * update readme * linting * Add method to import persisted model and allow user to set env variable * pickle is not needed anymore in the server file * add workaround for using pickle with gunicorn * linting --------- Co-authored-by: Tarun <tarsuno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now the current setup allows the deployment through linux services. However, being able to deploy the through docker would allow anyone to easily run the full setup with a single command. With this Pull Request, we intend to develop the needed files to deploy the application with Docker.
Description
We need to create a docker-compose file and allow all the needed variables through the environment variables.
TODOs:
Proof
Notes
We still need to figure out what is the best way to use the model inside the application, we we need to provide the path and mount the volume so that it is accesible.