Add automated test case for OCP-24688#68
Open
hu-weihua wants to merge 15 commits intomigtools:masterfrom
Open
Conversation
fbladilo
reviewed
Feb 7, 2020
Contributor
fbladilo
left a comment
fbladilo
left a comment
There was a problem hiding this comment.
Can we change these ansible module calls for k8s_facts, k8s_info is not available on ansible-2.8.x (RHEL7.x)
Contributor
|
@hu-weihua Also could you briefly describe the test logic on the PR, I don't seem to have access to the reference... |
Contributor
Author
|
@fbladilo Thank you for all you comments.
If you have any other question or comment, feel free to let me know, Thanks again. |
fbladilo
reviewed
Feb 18, 2020
| @@ -0,0 +1,16 @@ | |||
| - name: get all storageclasses infornamtion of migration target cluster | |||
fbladilo
reviewed
Feb 18, 2020
| @@ -0,0 +1,88 @@ | |||
| - name: get all storageclasses infornamtion of migration target cluster | |||
Contributor
There was a problem hiding this comment.
small typo also in information
fbladilo
reviewed
Feb 18, 2020
| state: absent | ||
| when: source_cluster_sc_name_list_tmp_file is defined | ||
|
|
||
| - name: sleep a while to wait configuration working |
Contributor
There was a problem hiding this comment.
We could use the pause module with seconds 60 on this instead of calling the shell module, ideally we would check for the condition expected in a loop with retries perhaps until it is satisfied....
Contributor
|
@hu-weihua Thanks for the revision, I added some other minor comments since last review. I tested the PR on a 3.11 source and 4.2 target (using CAM v1.0.1) , the first run was successful on both source and destination. The second time, it failed retrying on the destination cluster , see below : Something is probably not cleaned up correctly on the target deploy/validation, it exhibits the issue when it is run the second consecutive time, you should be able to reproduce just by running twice on the destination/target cluster : ansible-playbook e2e_mig_samples.yml -t ocp-24688-storageclasses -e with_deploy=false |
Contributor
|
@hu-weihua Let me know how to proceed with this one, I made another revision back in Feb with some comments/experience with it. |
Contributor
Author
|
@fbladilo Thanks a lot for your valuable comments and sorry to reply later. I have updated the typos and replaced But I did not hit your problem pasted above. I rerun the test in same test environment many times without below error. My test result in target cluster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is used to automate test case OCP-24688