Update Dockerfile and playbook for newer operator-sdk and ansible#883
Open
jmontleon wants to merge 1 commit intomigtools:masterfrom
Open
Update Dockerfile and playbook for newer operator-sdk and ansible#883jmontleon wants to merge 1 commit intomigtools:masterfrom
jmontleon wants to merge 1 commit intomigtools:masterfrom
Conversation
dymurray
approved these changes
Jul 28, 2023
pranavgaikwad
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like we're supposed to be installing this now from a requirements.yml.
As an example:
https://github.com/operator-framework/operator-sdk/blob/master/testdata/ansible/memcached-operator/Dockerfile
https://github.com/operator-framework/operator-sdk/blob/master/testdata/ansible/memcached-operator/requirements.yml
k8s_factsare also good and gone now so we need to replace them withk8s_info.