add reorder selection property when order in selectize has been changed#96
Open
mszoernyi wants to merge 5 commits intomiguelcobain:masterfrom
Open
add reorder selection property when order in selectize has been changed#96mszoernyi wants to merge 5 commits intomiguelcobain:masterfrom
mszoernyi wants to merge 5 commits intomiguelcobain:masterfrom
Conversation
addon/components/ember-selectize.js
Outdated
Owner
There was a problem hiding this comment.
Looks like we have onItemAdd set two times here.
Author
|
Did some refactoring to get the tests green but I couldn't find a better solution for this: mszoernyi@6ce8e6d#diff-d0312fe215da74aeb01ef78212c49b42R356 Any suggestions for this? |
Author
|
Any updates on this? |
Owner
|
Still didn't have the time to review this, @mszoernyi. Sorry. |
Contributor
|
actually I tried it and it stuck in the endless loop with addItem, onChange events. |
Author
|
seems like doesn't work with the latest version. Will check when I get some time. I'm using this code with |
Contributor
|
@mszoernyi then there is no need to this PR, I guess? It is a bit misleading, though, it gave me a couple of ideas. |
|
is there any other solution for selection ordering when drag_drop plugin is used? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92
I'm not quite sure if the tests are enough and would appreciate some guidance :-)