Be consistent storing property variant information #79
+24
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces Variant from 8 to 4 bytes Variant information stored in parent object
mikee47
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #77 has arisen as a consequence of space-optimisation. Range information is stored in the
PropertyInfo::Variantunion as two 32-bit values for regular integers, but as a pointer to the information for 64-bit values. This PR fixes that inconsistency so that all range information is stored indirectly. This also reduces flash storage slightly since the size of this union is reduced from 8 to 4 bytes. TheRangefor all properties are now defined in the parent object definition.