Fallback to matching filename with grepformat.#258
Open
DArtagan wants to merge 1 commit intomileszs:masterfrom
Open
Fallback to matching filename with grepformat.#258DArtagan wants to merge 1 commit intomileszs:masterfrom
DArtagan wants to merge 1 commit intomileszs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When one uses the
-loption to look for just files containing a search term, but not every result:The current results look like:
Which breaks the quickfix list's ability to jump.
With this changes, the results will now look like:
Full confession: I'm a ag-based searcher. And this use case only appears when using a custom
ackprgvalue. Otherwise the default-Hand the-loptions are mutually exclusive in ack.