Open
Conversation
0w0n2
reviewed
Mar 1, 2026
| @Slf4j | ||
| public class JwtChannelInterceptor implements ChannelInterceptor { | ||
|
|
||
| private static final String AUTHORIZATION = "Authorization"; |
Member
There was a problem hiding this comment.
문자열 상수 직접 정의 대신 HttpHeaders.AUTHORIZATION 사용해보시는 건 어떤가요
| private static final String AUTHORIZATION = "Authorization"; | ||
| private static final String AUTHORIZATION_LOWER = "authorization"; | ||
| private static final String SENDER_ID_SESSION_KEY = "senderId"; | ||
| private static final String GRANT_TYPE = "Bearer "; |
Member
There was a problem hiding this comment.
GRANT_TYPE은 이미 SecurityConstants.Token.GRANT_TYPE 에 공통 상수로 정해져 있는데 대신 사용해보시는 건 어떤가요
Comment on lines
+108
to
+110
| // 혹시 "Bearer"만 있는 형태도 대비 | ||
| if (rawHeader.startsWith("Bearer ")) { | ||
| return rawHeader.substring("Bearer ".length()).trim(); |
Member
There was a problem hiding this comment.
"Bearer " 이 위에서 상수로 정의되어있는데 여기선 하드코딩 되어있습니다
Member
There was a problem hiding this comment.
JwtTokenProvider 클래스와 JwtAuthenticationService#getAuthentication에 제가 JWT 토큰 관련한 util 메소드를 넣어두었는데 이 클래스에서 활용하긴 어려울까요 ??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Connected Issue
Closes #(이슈번호)
📅 Development Period
(ex. YYYY.MM.DD ~ YYYY.MM.DD)
📢 Description
stomp jwtInterceptor 구현
✔️ PR Checklist
MR이 아래 사항을 충족하는지 확인해주세요:
🔖 Note
테스트를 못해봐서 제대로 동작할런지 모르겠어용..