Skip to content

Add register permission #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
taran-p wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add register permission #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1743c5f
add register permission
taran-p Dec 7, 2025
93cd921
condition key
taran-p Dec 12, 2025
d8b175d
Merge branch 'minio:main' into register-perm
taran-p Dec 12, 2025
da5182b
Merge branch 'minio:main' into register-perm
taran-p Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions policy/condition/keyname.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ const (
// S3TablesViewName filters access by the S3 Tables view name within a namespace.
S3TablesViewName KeyName = "s3tables:viewName"

// S3TablesRegisterLocation filters access by the metadata location for table registration.
S3TablesRegisterLocation KeyName = "s3tables:registerLocation"

// S3XAmzCopySource - key representing x-amz-copy-source HTTP header applicable to PutObject API only.
S3XAmzCopySource KeyName = "s3:x-amz-copy-source"

Expand Down Expand Up @@ -289,6 +292,7 @@ var AllSupportedKeys = []KeyName{
S3TablesNamespace,
S3TablesTableName,
S3TablesViewName,
S3TablesRegisterLocation,
AWSReferer,
AWSSourceIP,
AWSUserAgent,
Expand Down
7 changes: 7 additions & 0 deletions policy/table-action.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ const (
// S3TablesPutTablePolicyAction maps to the AWS `PutTablePolicy` S3 Tables action.
S3TablesPutTablePolicyAction = "s3tables:PutTablePolicy"

// S3TablesRegisterTableAction maps to the AWS `RegisterTable` S3 Tables action.
S3TablesRegisterTableAction = "s3tables:RegisterTable"

// S3TablesRenameTableAction maps to the AWS `RenameTable` S3 Tables action.
S3TablesRenameTableAction = "s3tables:RenameTable"

Expand Down Expand Up @@ -239,6 +242,7 @@ var SupportedTableActions = map[TableAction]struct{}{
S3TablesPutTableEncryptionAction: {},
S3TablesPutTableMaintenanceConfigurationAction: {},
S3TablesPutTablePolicyAction: {},
S3TablesRegisterTableAction: {},
S3TablesRenameTableAction: {},
S3TablesUpdateTableMetadataLocationAction: {},
S3TablesCreateWarehouseAction: {},
Expand Down Expand Up @@ -283,6 +287,7 @@ func createTableActionConditionKeyMap() map[Action]condition.KeySet {
s3TablesViewNameKey := condition.S3TablesViewName.ToKey()
s3TablesKMSKeyKey := condition.S3TablesKMSKeyArn.ToKey()
s3TablesSSEAlgorithmKey := condition.S3TablesSSEAlgorithm.ToKey()
s3TablesRegisterLocationKey := condition.S3TablesRegisterLocation.ToKey()

withCommon := func(keys ...condition.Key) condition.KeySet {
merged := append([]condition.Key{}, commonKeys...)
Expand All @@ -302,6 +307,7 @@ func createTableActionConditionKeyMap() map[Action]condition.KeySet {
s3TablesViewNameKey,
s3TablesKMSKeyKey,
s3TablesSSEAlgorithmKey,
s3TablesRegisterLocationKey,
)
tableActionConditionKeyMap[S3TablesCreateNamespaceAction] = withCommon()
tableActionConditionKeyMap[S3TablesCreateTableAction] = withCommon(s3TablesNamespaceKey, s3TablesKMSKeyKey, s3TablesSSEAlgorithmKey)
Expand Down Expand Up @@ -334,6 +340,7 @@ func createTableActionConditionKeyMap() map[Action]condition.KeySet {
tableActionConditionKeyMap[S3TablesPutTableEncryptionAction] = withCommon(s3TablesNamespaceKey, s3TablesKMSKeyKey, s3TablesSSEAlgorithmKey)
tableActionConditionKeyMap[S3TablesPutTableMaintenanceConfigurationAction] = withCommon(s3TablesNamespaceKey, s3TablesTableNameKey)
tableActionConditionKeyMap[S3TablesPutTablePolicyAction] = withCommon(s3TablesNamespaceKey, s3TablesTableNameKey)
tableActionConditionKeyMap[S3TablesRegisterTableAction] = withCommon(s3TablesNamespaceKey, s3TablesTableNameKey, s3TablesRegisterLocationKey)
tableActionConditionKeyMap[S3TablesRenameTableAction] = withCommon(s3TablesNamespaceKey, s3TablesTableNameKey)
tableActionConditionKeyMap[S3TablesUpdateTableMetadataLocationAction] = withCommon(s3TablesNamespaceKey, s3TablesTableNameKey)
tableActionConditionKeyMap[S3TablesCreateWarehouseAction] = withCommon(s3TablesKMSKeyKey, s3TablesSSEAlgorithmKey)
Expand Down
Loading